Chromium Code Reviews
DescriptionPDF viewer: Specify that the touchstart listener not be passive.
In the PDF viewer's touchstart listener, we call preventDefault on
two finger touches to prevent native pinch-zoom. Hence, this listener
cannot be passive.
Currently, we do not specify whether our touch handlers are passive,
so if listeners are passive by default, the call to preventDefault
is ignored and native pinch-zoom is invoked.
We now specify the passive option when adding touch event listeners.
BUG=675730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2584393003
Cr-Commit-Position: refs/heads/master@{#440440}
(cherry picked from commit 16b6154685aff544f8870a8ca164d0181881c038)
Review-Url: https://codereview.chromium.org/2612773006 .
Cr-Commit-Position: refs/branch-heads/2924@{#686}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/f588786d5f3fa1d4e4190111bd55f892b04b398a
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||