Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2584393003:
PDF viewer: Specify that the touchstart listener not be passive. (Closed)
|
Created:
4 years ago by Kevin McNee Modified:
4 years ago CC:
chromium-reviews, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPDF viewer: Specify that the touchstart listener not be passive.
In the PDF viewer's touchstart listener, we call preventDefault on
two finger touches to prevent native pinch-zoom. Hence, this listener
cannot be passive.
Currently, we do not specify whether our touch handlers are passive,
so if listeners are passive by default, the call to preventDefault
is ignored and native pinch-zoom is invoked.
We now specify the passive option when adding touch event listeners.
BUG=675730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/16b6154685aff544f8870a8ca164d0181881c038
Cr-Commit-Position: refs/heads/master@{#440440}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 ========== to ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mcnee@chromium.org changed reviewers: + raymes@chromium.org
Hello, raymes@. Can you take a look at this change?
The CQ bit was checked by mcnee@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It looks like dpapad and bokan reviewed this code previously. Could one of them take a look? Happy to rubberstamp after.
Description was changed from ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mcnee@chromium.org changed reviewers: + bokan@chromium.org
bokan@: Hi. Could you take a look at this change?
lgtm
lgtm
The CQ bit was checked by mcnee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482420763570430, "parent_rev":
"2552e4f227163eab9d9f1eb3ccd6a8aa769dda65", "commit_rev":
"b4f2ef26f039fae978a012f0cfd4f0033a1e1eea"}
Message was sent while issue was closed.
Description was changed from ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2584393003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2584393003 ========== to ========== PDF viewer: Specify that the touchstart listener not be passive. In the PDF viewer's touchstart listener, we call preventDefault on two finger touches to prevent native pinch-zoom. Hence, this listener cannot be passive. Currently, we do not specify whether our touch handlers are passive, so if listeners are passive by default, the call to preventDefault is ignored and native pinch-zoom is invoked. We now specify the passive option when adding touch event listeners. BUG=675730 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/16b6154685aff544f8870a8ca164d0181881c038 Cr-Commit-Position: refs/heads/master@{#440440} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/16b6154685aff544f8870a8ca164d0181881c038 Cr-Commit-Position: refs/heads/master@{#440440} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
