Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2612633002: CrOS Alt+Tab UI: no-op when UI is aborted (instead of switching window). (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS Alt+Tab UI: no-op when UI is aborted (instead of switching window). Also, remove the old pre-MD code for window switching & activation. BUG=648351 Committed: https://crrev.com/bfcf715cb1a1dca220fdbbc662c4f875a2dbc26b Cr-Commit-Position: refs/heads/master@{#441242}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -144 lines) Patch
M ash/common/wm/window_cycle_controller.h View 2 chunks +10 lines, -4 lines 0 comments Download
M ash/common/wm/window_cycle_controller.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/common/wm/window_cycle_list.h View 3 chunks +10 lines, -8 lines 0 comments Download
M ash/common/wm/window_cycle_list.cc View 8 chunks +4 lines, -105 lines 2 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 18 chunks +30 lines, -25 lines 0 comments Download
M ash/wm/window_cycle_event_filter_aura.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Evan Stade
3 years, 11 months ago (2017-01-03 22:17:30 UTC) #2
varkha
lgtm. https://codereview.chromium.org/2612633002/diff/1/ash/common/wm/window_cycle_list.cc File ash/common/wm/window_cycle_list.cc (left): https://codereview.chromium.org/2612633002/diff/1/ash/common/wm/window_cycle_list.cc#oldcode428 ash/common/wm/window_cycle_list.cc:428: ScopedShowWindow::ScopedShowWindow() Since you are removing this pre-MD path, ...
3 years, 11 months ago (2017-01-03 22:38:52 UTC) #5
Evan Stade
https://codereview.chromium.org/2612633002/diff/1/ash/common/wm/window_cycle_list.cc File ash/common/wm/window_cycle_list.cc (left): https://codereview.chromium.org/2612633002/diff/1/ash/common/wm/window_cycle_list.cc#oldcode428 ash/common/wm/window_cycle_list.cc:428: ScopedShowWindow::ScopedShowWindow() On 2017/01/03 22:38:51, varkha wrote: > Since you ...
3 years, 11 months ago (2017-01-03 22:41:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612633002/1
3 years, 11 months ago (2017-01-03 23:10:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 23:15:04 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:18:54 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfcf715cb1a1dca220fdbbc662c4f875a2dbc26b
Cr-Commit-Position: refs/heads/master@{#441242}

Powered by Google App Engine
This is Rietveld 408576698