Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: ash/common/wm/window_cycle_controller.h

Issue 2612633002: CrOS Alt+Tab UI: no-op when UI is aborted (instead of switching window). (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/wm/window_cycle_controller.cc » ('j') | ash/common/wm/window_cycle_list.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/window_cycle_controller.h
diff --git a/ash/common/wm/window_cycle_controller.h b/ash/common/wm/window_cycle_controller.h
index 4544f492458dbf568c0c60a95ed35fd0b223b265..87eedd9a2140bd127d822924373f999bb1e67592 100644
--- a/ash/common/wm/window_cycle_controller.h
+++ b/ash/common/wm/window_cycle_controller.h
@@ -45,10 +45,14 @@ class ASH_EXPORT WindowCycleController {
// listen to the alt key release.
void StartCycling();
- // Stops the current window cycle and removes the event filter.
- void StopCycling();
-
- // Returns the WindowCycleList. Really only useful for testing.
+ // Both of these functions stop the current window cycle and removes the event
+ // filter. The former indicates success (i.e. the new window should be
+ // activated) and the latter indicates that the interaction was cancelled (and
+ // the originally active window should remain active).
+ void CompleteCycling();
+ void CancelCycling();
+
+ // Returns the WindowCycleList.
const WindowCycleList* window_cycle_list() const {
return window_cycle_list_.get();
}
@@ -57,6 +61,8 @@ class ASH_EXPORT WindowCycleController {
// Cycles to the next or previous window based on |direction|.
void Step(Direction direction);
+ void StopCycling();
+
std::unique_ptr<WindowCycleList> window_cycle_list_;
// Tracks what Window was active when starting to cycle and used to determine
« no previous file with comments | « no previous file | ash/common/wm/window_cycle_controller.cc » ('j') | ash/common/wm/window_cycle_list.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698