Fix memory corruption during launching an app from shortcut.

chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h"
 
 #include <stddef.h>
 
 #include "ash/wm/window_util.h"
 #include "chrome/browser/chromeos/arc/arc_support_host.h"
@@ skipping 91 matching lines @@
   for (size_t i = 0; i < content.size(); i++) {
     Browser* browser = chrome::FindBrowserWithWebContents(content[i]);
     if (browser && browser->window()->GetNativeWindow()->IsVisible())
       return true;
   }
   return false;
 }
 
 void AppShortcutLauncherItemController::Launch(ash::LaunchSource source,
                                                int event_flags) {
-  launcher_controller()->LaunchAppWithLaunchId(app_id(), launch_id(), source,
-                                               event_flags);
+  // Launching an app replaces shortcut item controller to app controller. As
+  // result app_id_, launch_id_ are deleted during this call. Use local copies
+  // to prevent crash condition.
+  launcher_controller()->LaunchAppWithLaunchId(
+      std::string(app_id()), std::string(launch_id()), source, event_flags);
 }
 
 ash::ShelfItemDelegate::PerformedAction
 AppShortcutLauncherItemController::Activate(ash::LaunchSource source) {
   content::WebContents* content = GetLRUApplication();
   if (!content) {
     if (IsV2App()) {
       // Ideally we come here only once. After that ShellLauncherItemController
       // will take over when the shell window gets opened. However there are
       // apps which take a lot of time for pre-processing (like the files app)
@@ skipping 241 matching lines @@
 
 bool AppShortcutLauncherItemController::AllowNextLaunchAttempt() {
   if (last_launch_attempt_.is_null() ||
       last_launch_attempt_ + base::TimeDelta::FromMilliseconds(
           kClickSuppressionInMS) < base::Time::Now()) {
     last_launch_attempt_ = base::Time::Now();
     return true;
   }
   return false;
 }