Release video frames earlier in MediaRecorder

Release video frames earlier in Media Recorder	

This CL tries to shorten the lifetime of VideoFrames that go to MediaRecorder sink.
In order to release frames earlier, the video parameters that WebmMuxer later needs
are stored in VideoParameters struct and passed. 

BUG=678095
TEST=Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264/VPX on Mac.

Review-Url: https://codereview.chromium.org/2612403002
Cr-Commit-Position: refs/heads/master@{#441851}
Committed: https://chromium.googlesource.com/chromium/src/+/8bddd84ffe3009bd204fc3ed94464af46ed4d872

[emircan, 2017-01-06 00:26:55]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-01-06 00:29:32]

Patchset #1 (id:1) has been deleted

[emircan, 2017-01-06 00:33:32]

Description was changed from

==========
early rel

BUG=
==========

to

==========
Release video frames earlier in Media Recorder	

This CL tries to shorten the lifetime of VideoFrames that go to MediaRecorder
sink.
In order to release frames earlier, the video parameters that WebmMuxer later
needs
are stored in VideoParameters struct and passed. 

BUG=678095
TEST=Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264/VPX on Mac.
==========

[emircan, 2017-01-06 00:33:32]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2017-01-06 00:33:41]

PTAL.

[emircan, 2017-01-06 00:36:01]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[emircan, 2017-01-06 00:36:07]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-06 00:36:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-01-06 01:04:55]

lgtm w/ tiny comments.

https://codereview.chromium.org/2612403002/diff/40001/content/renderer/media/...
File content/renderer/media/video_track_recorder.cc (right):

https://codereview.chromium.org/2612403002/diff/40001/content/renderer/media/...
content/renderer/media/video_track_recorder.cc:774:
media::WebmMuxer::VideoParameters video_params(frame);
const? Also in l.970

https://codereview.chromium.org/2612403002/diff/40001/media/muxers/webm_muxer.h
File media/muxers/webm_muxer.h (right):

https://codereview.chromium.org/2612403002/diff/40001/media/muxers/webm_muxer...
media/muxers/webm_muxer.h:56: gfx::Size frame_size;
nit: s/frame_size/visible_rect_size/ to
preserve the original meaning?

[emircan, 2017-01-06 01:18:15]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[emircan, 2017-01-06 01:19:13]

https://codereview.chromium.org/2612403002/diff/40001/content/renderer/media/...
File content/renderer/media/video_track_recorder.cc (right):

https://codereview.chromium.org/2612403002/diff/40001/content/renderer/media/...
content/renderer/media/video_track_recorder.cc:774:
media::WebmMuxer::VideoParameters video_params(frame);
On 2017/01/06 01:04:55, mcasas wrote:
> const? Also in l.970

Done.

https://codereview.chromium.org/2612403002/diff/40001/media/muxers/webm_muxer.h
File media/muxers/webm_muxer.h (right):

https://codereview.chromium.org/2612403002/diff/40001/media/muxers/webm_muxer...
media/muxers/webm_muxer.h:56: gfx::Size frame_size;
On 2017/01/06 01:04:55, mcasas wrote:
> nit: s/frame_size/visible_rect_size/ to
> preserve the original meaning?

Done.

[commit-bot: I haz the power, 2017-01-06 01:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-01-06 01:30:42]

The CQ bit was unchecked by emircan@chromium.org

[emircan, 2017-01-06 01:30:43]

The CQ bit was checked by emircan@chromium.org

[emircan, 2017-01-06 01:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2612403002/#ps60001
(title: "mcasas@ nits.")

[commit-bot: I haz the power, 2017-01-06 01:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:50:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483666243363630,
"parent_rev": "8e659c584c519c09430f536788b6ac45400eeccc", "commit_rev":
"8bddd84ffe3009bd204fc3ed94464af46ed4d872"}

[commit-bot: I haz the power, 2017-01-06 02:51:26]

Description was changed from

==========
Release video frames earlier in Media Recorder	

This CL tries to shorten the lifetime of VideoFrames that go to MediaRecorder
sink.
In order to release frames earlier, the video parameters that WebmMuxer later
needs
are stored in VideoParameters struct and passed. 

BUG=678095
TEST=Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264/VPX on Mac.
==========

to

==========
Release video frames earlier in Media Recorder	

This CL tries to shorten the lifetime of VideoFrames that go to MediaRecorder
sink.
In order to release frames earlier, the video parameters that WebmMuxer later
needs
are stored in VideoParameters struct and passed. 

BUG=678095
TEST=Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264/VPX on Mac.

Review-Url: https://codereview.chromium.org/2612403002
Cr-Commit-Position: refs/heads/master@{#441851}
Committed:
https://chromium.googlesource.com/chromium/src/+/8bddd84ffe3009bd204fc3ed9446...
==========

[commit-bot: I haz the power, 2017-01-06 02:51:27]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8bddd84ffe3009bd204fc3ed9446...