Release video frames earlier in MediaRecorder

media/muxers/webm_muxer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_MUXERS_WEBM_MUXER_H_
 #define MEDIA_MUXERS_WEBM_MUXER_H_
 
 #include <stdint.h>
 
 #include <deque>
 #include <memory>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/numerics/safe_math.h"
 #include "base/strings/string_piece.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 #include "base/timer/elapsed_timer.h"
 #include "media/base/media_export.h"
 #include "media/base/video_codecs.h"
 #include "third_party/libwebm/source/mkvmuxer.hpp"
+#include "ui/gfx/geometry/size.h"
 
 namespace gfx {
 class Size;
 }  // namespace gfx
 
 namespace media {
 
 class VideoFrame;
 class AudioParameters;
 
 // Adapter class to manage a WebM container [1], a simplified version of a
 // Matroska container [2], composed of an EBML header, and a single Segment
 // including at least a Track Section and a number of SimpleBlocks each
 // containing a single encoded video or audio frame. WebM container has no
 // Trailer.
 // Clients will push encoded VPx video frames and Opus audio frames one by one
 // via OnEncoded{Video|Audio}(). libwebm will eventually ping the WriteDataCB
 // passed on contructor with the wrapped encoded data.
 // WebmMuxer is designed for use on a single thread.
 // [1] http://www.webmproject.org/docs/container/
 // [2] http://www.matroska.org/technical/specs/index.html
 class MEDIA_EXPORT WebmMuxer : public NON_EXPORTED_BASE(mkvmuxer::IMkvWriter) {
  public:
   // Callback to be called when WebmMuxer is ready to write a chunk of data,
   // either any file header or a SingleBlock.
   using WriteDataCB = base::Callback<void(base::StringPiece)>;
 
+  // Container for the parameters that muxer uses that is extracted from
+  // media::VideoFrame.
+  struct MEDIA_EXPORT VideoParameters {
+    VideoParameters(scoped_refptr<media::VideoFrame> frame);
+    ~VideoParameters();
+    gfx::Size frame_size;

[mcasas, 2017/01/06 01:04:55]

nit: s/frame_size/visible_rect_size/ to
preserve the original meaning?

[emircan, 2017/01/06 01:19:13]

Done.

+    double frame_rate;
+  };
+
   // |codec| can be VP8 or VP9 and should coincide with whatever is sent in
   // OnEncodedVideo().
   WebmMuxer(VideoCodec codec,
             bool has_video_,
             bool has_audio_,
             const WriteDataCB& write_data_callback);
   ~WebmMuxer() override;
 
   // Functions to add video and audio frames with |encoded_data.data()|
   // to WebM Segment.
-  void OnEncodedVideo(const scoped_refptr<VideoFrame>& video_frame,
+  void OnEncodedVideo(const VideoParameters& params,
                       std::unique_ptr<std::string> encoded_data,
                       base::TimeTicks timestamp,
                       bool is_key_frame);
   void OnEncodedAudio(const media::AudioParameters& params,
                       std::unique_ptr<std::string> encoded_data,
                       base::TimeTicks timestamp);
 
   void Pause();
   void Resume();
 
@@ skipping 72 matching lines @@
     DISALLOW_IMPLICIT_CONSTRUCTORS(EncodedVideoFrame);
   };
   std::deque<std::unique_ptr<EncodedVideoFrame>> encoded_frames_queue_;
 
   DISALLOW_COPY_AND_ASSIGN(WebmMuxer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_MUXERS_WEBM_MUXER_H_