DevTools: Show FMP markers on timeline experiment

DevTools: Show FMP markers on timeline experiment

Review-Url: https://codereview.chromium.org/2612363003
Cr-Commit-Position: refs/heads/master@{#442125}
Committed: https://chromium.googlesource.com/chromium/src/+/68f0df28fa1aac95c808428f3b79846f99c73547

[alph, 2017-01-05 23:52:04]

alph@chromium.org changed reviewers:
+ paulirish@chromium.org, pfeldman@chromium.org

[pfeldman, 2017-01-06 00:05:59]

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:113:
Runtime.experiments.register('timelineShowFMP', 'Show first meaningful paint
marker on Timeline', true);
timelinePaintTimingMarkers

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:1201:
FMPCandidate: 'firstMeaningfulPaintCandidate',
firstMeaningfulPaint also exists. And we can display more paint events.

[alph, 2017-01-06 01:56:48]

ptal

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:113:
Runtime.experiments.register('timelineShowFMP', 'Show first meaningful paint
marker on Timeline', true);
On 2017/01/06 00:05:59, pfeldman wrote:
> timelinePaintTimingMarkers

Done.

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2612363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:1201:
FMPCandidate: 'firstMeaningfulPaintCandidate',
On 2017/01/06 00:05:59, pfeldman wrote:
> firstMeaningfulPaint also exists. And we can display more paint events.

Done.

[pfeldman, 2017-01-06 02:31:33]

lgtm

[alph, 2017-01-06 23:43:18]

Patchset #3 (id:40001) has been deleted

[alph, 2017-01-06 23:46:03]

The CQ bit was checked by alph@chromium.org

[alph, 2017-01-06 23:46:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2612363003/#ps60001
(title: "tweaks")

[commit-bot: I haz the power, 2017-01-06 23:46:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 01:13:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483746363947920,
"parent_rev": "bd2449f5de94d47bf4b33c439021897a8f3a86d0", "commit_rev":
"68f0df28fa1aac95c808428f3b79846f99c73547"}

[commit-bot: I haz the power, 2017-01-07 01:13:52]

Description was changed from

==========
DevTools: Show FMP markers on timeline experiment
==========

to

==========
DevTools: Show FMP markers on timeline experiment

Review-Url: https://codereview.chromium.org/2612363003
Cr-Commit-Position: refs/heads/master@{#442125}
Committed:
https://chromium.googlesource.com/chromium/src/+/68f0df28fa1aac95c808428f3b79...
==========

[commit-bot: I haz the power, 2017-01-07 01:13:53]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/68f0df28fa1aac95c808428f3b79...