Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2612363003: DevTools: Show FMP markers on timeline experiment (Closed)
Patch Set: tweaks Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
index 0460886d28835fcfc1422034a54c31611efb6435..fa3e9ee697479d2783fc32c88317a01592af6eb4 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
@@ -104,10 +104,15 @@ TimelineModel.TimelineModel = class {
* @return {boolean}
*/
static isMarkerEvent(event) {
- var recordTypes = TimelineModel.TimelineModel.RecordType;
+ const recordTypes = TimelineModel.TimelineModel.RecordType;
switch (event.name) {
case recordTypes.TimeStamp:
case recordTypes.MarkFirstPaint:
+ case recordTypes.FirstTextPaint:
+ case recordTypes.FirstImagePaint:
+ case recordTypes.FirstMeaningfulPaint:
+ case recordTypes.FirstPaint:
+ case recordTypes.FirstContentfulPaint:
return true;
case recordTypes.MarkDOMContent:
case recordTypes.MarkLoad:
@@ -1202,6 +1207,12 @@ TimelineModel.TimelineModel.RecordType = {
ConsoleTime: 'ConsoleTime',
UserTiming: 'UserTiming',
+ FirstTextPaint: 'firstTextPaint',
+ FirstImagePaint: 'firstImagePaint',
+ FirstMeaningfulPaint: 'firstMeaningfulPaint',
+ FirstPaint: 'firstPaint',
+ FirstContentfulPaint: 'firstContentfulPaint',
+
ResourceSendRequest: 'ResourceSendRequest',
ResourceReceiveResponse: 'ResourceReceiveResponse',
ResourceReceivedData: 'ResourceReceivedData',
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698