Add --disable-slimming-paint-invalidation

Add --disable-slimming-paint-invalidation

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
TBR=achuith@chromium.org (for chrome/browser/chromeos/login/chrome_restart_request.cc)
R=pdr@chromium.org,creis@chromium.org,holte@chromium.org

Review-Url: https://codereview.chromium.org/2612323002
Cr-Commit-Position: refs/heads/master@{#441959}
Committed: https://chromium.googlesource.com/chromium/src/+/3240715025d4a6f689a9c56ef5fdf9a48b0a20e1

[Xianzhu, 2017-01-05 19:34:58]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 19:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-05 19:38:30]

wangxianzhu@chromium.org changed reviewers:
+ creis@chromium.org, holte@chromium.org, jochen@chromium.org, pdr@chromium.org

[Xianzhu, 2017-01-05 19:38:31]

Ptal:

creis: content/
jochen: chrome/
holte: histograms.xml

Thanks.

[pdr., 2017-01-05 20:26:14]

Why would anyone want to disable our awesome new code?

LGTM anyway

[Xianzhu, 2017-01-05 20:29:06]

On 2017/01/05 20:26:14, pdr. wrote:
> Why would anyone want to disable our awesome new code?
> 
> LGTM anyway

This is mainly for testing. When there is some bug, we can try to disable the
feature to see if it's a problem of it.

[pdr., 2017-01-05 20:31:31]

On 2017/01/05 at 20:29:06, wangxianzhu wrote:
> On 2017/01/05 20:26:14, pdr. wrote:
> > Why would anyone want to disable our awesome new code?
> > 
> > LGTM anyway
> 
> This is mainly for testing. When there is some bug, we can try to disable the
feature to see if it's a problem of it.

Definitely, I was just being silly :)

[Charlie Reis, 2017-01-05 20:35:39]

content/ LGTM with nits.

https://codereview.chromium.org/2612323002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2612323002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1716:
switches::kDisableSlimmingPaintInvalidation,
nit: Alphabetize to be consistent with the rest of the list.

https://codereview.chromium.org/2612323002/diff/1/content/public/common/conte...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2612323002/diff/1/content/public/common/conte...
content/public/common/content_switches.h:148: CONTENT_EXPORT extern const char
kDisableSlimmingPaintInvalidation[];
Same here and in .cc file.

https://codereview.chromium.org/2612323002/diff/1/content/public/common/conte...
content/public/common/content_switches.h:330: // alphabetical order, or in one
of the ifdefs (also in order in each section).
This is why.  :)

[commit-bot: I haz the power, 2017-01-05 20:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:57:59]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-01-05 21:39:43]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-01-05 21:39:47]

https://codereview.chromium.org/2612323002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2612323002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1716:
switches::kDisableSlimmingPaintInvalidation,
On 2017/01/05 20:35:39, Charlie Reis wrote:
> nit: Alphabetize to be consistent with the rest of the list.

Done.

https://codereview.chromium.org/2612323002/diff/1/content/public/common/conte...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/2612323002/diff/1/content/public/common/conte...
content/public/common/content_switches.h:148: CONTENT_EXPORT extern const char
kDisableSlimmingPaintInvalidation[];
On 2017/01/05 20:35:39, Charlie Reis wrote:
> Same here and in .cc file.

Done.

[commit-bot: I haz the power, 2017-01-05 21:40:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Steven Holte, 2017-01-05 21:53:59]

histograms lgtm

[commit-bot: I haz the power, 2017-01-05 23:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:05:04]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-01-06 17:11:05]

Description was changed from

==========
Add --disable-slimming-paint-invalidation

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
==========

to

==========
Add --disable-slimming-paint-invalidation

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
TBR=achuith@chromium.org (for
chrome/browser/chromeos/login/chrome_restart_request.cc)
R=pdr@chromium.org,creis@chromium.org,holte@chromium.org
==========

[Xianzhu, 2017-01-06 17:11:05]

wangxianzhu@chromium.org changed reviewers:
+ achuith@chromium.org

[Xianzhu, 2017-01-06 17:11:10]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-01-06 17:11:10]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2612323002/#ps20001
(title: "Alphabetize")

[commit-bot: I haz the power, 2017-01-06 17:11:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:16:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483722670515980,
"parent_rev": "929f43478f9acb732ce04c4a1209cf3cd1b7a582", "commit_rev":
"3240715025d4a6f689a9c56ef5fdf9a48b0a20e1"}

[commit-bot: I haz the power, 2017-01-06 17:17:08]

Description was changed from

==========
Add --disable-slimming-paint-invalidation

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
TBR=achuith@chromium.org (for
chrome/browser/chromeos/login/chrome_restart_request.cc)
R=pdr@chromium.org,creis@chromium.org,holte@chromium.org
==========

to

==========
Add --disable-slimming-paint-invalidation

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
TBR=achuith@chromium.org (for
chrome/browser/chromeos/login/chrome_restart_request.cc)
R=pdr@chromium.org,creis@chromium.org,holte@chromium.org

Review-Url: https://codereview.chromium.org/2612323002
Cr-Commit-Position: refs/heads/master@{#441959}
Committed:
https://chromium.googlesource.com/chromium/src/+/3240715025d4a6f689a9c56ef5fd...
==========

[commit-bot: I haz the power, 2017-01-06 17:17:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3240715025d4a6f689a9c56ef5fd...