Run paint/invalidation with --disable-slimming-paint-invalidation

Run paint/invalidation with --disable-slimming-paint-invalidation

Run paint/invalidation with SlimmingPaintInvalidation disabled to ensure
test coverage of the non-SlimmingPaintInvalidation path when
SlimmingPaintInvalidation is enabled for
virtual/spinvalidation/paint/invalidation and all other layout tests.

Not adding something like virtual/non-spinvalidation/paint/invalidation
to avoid copying baselines as now paint/invalidation baselines are
baselines of non-spinvalidation.

BUG=646176

[Xianzhu, 2017-01-06 17:33:45]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 17:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-06 17:36:07]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2017-01-06 17:36:07]

We might still make changes to the old path and need to keep it work
for some time, so unskip paint/invalidation with
--disable-slimming-paint-invalidation
to ensure the test coverage.

[pdr., 2017-01-06 18:11:52]

On 2017/01/06 at 17:36:07, wangxianzhu wrote:
> We might still make changes to the old path and need to keep it work
> for some time, so unskip paint/invalidation with
--disable-slimming-paint-invalidation
> to ensure the test coverage.

LGTM with a question:
Are we ready to just run all tests with spinvalidation (runtimeenabledfeature =
test) and adding an oldPaintInvalidation virtual test suite? We're doing quite a
bit of work to essentially get that behavior.

[Xianzhu, 2017-01-06 18:45:00]

On 2017/01/06 18:11:52, pdr. wrote:
> On 2017/01/06 at 17:36:07, wangxianzhu wrote:
> > We might still make changes to the old path and need to keep it work
> > for some time, so unskip paint/invalidation with
> --disable-slimming-paint-invalidation
> > to ensure the test coverage.
> 
> LGTM with a question:
> Are we ready to just run all tests with spinvalidation (runtimeenabledfeature
=
> test) and adding an oldPaintInvalidation virtual test suite? We're doing quite
a
> bit of work to essentially get that behavior.

The current status=experimental already enabled spinvalidation for all layout
tests. Just investigated a little about the coverages of status=experimental and
status=test and still haven't figured all out. Will try to add a paragraph in
RuntimeEnabledFeatures.in after I figured something out.

Will consider to change (paint/invalidation with
--disable-slimming-paint-invalidation, virtual/spinvalidation/paint/invalidation
with --enable-slimming-paint-invalidation) to (paint/invalidation with
--enable-slimming-paint-invalidation,
virtual/non-spinvalidation/paint/invalidation) in the next week when we are have
more confidence.

[commit-bot: I haz the power, 2017-01-06 18:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:50:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-01-06 19:02:08]

The patch doesn't work as expected. Adding paint/invalidation as a physical test
suite somehow breaks virtual/spinvalidation/paint/invalidation. Will go ahead to
add a non-spinvalidation virtual suite instead.