Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].
And DOMRectInit is added[2].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect
[2] https://drafts.fxtf.org/geometry/#dictdef-domrectinit

BUG=678023
Review-Url: https://codereview.chromium.org/2612263002
Cr-Commit-Position: refs/heads/master@{#443878}
Committed: https://chromium.googlesource.com/chromium/src/+/5be3a2ab80dff22d41a0a5e99a586272208dac37

[Byoungkwon Ko, 2017-01-05 15:16:52]

Description was changed from

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

The two interfaces require fromRect function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect

BUG=678023
==========

to

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect

BUG=678023
==========

[Byoungkwon Ko, 2017-01-08 11:26:26]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-08 11:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-08 11:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-08 11:26:38]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Byoungkwon Ko, 2017-01-10 15:52:29]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 15:52:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 15:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 15:54:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-01-11 17:57:08]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:57:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-01-11 18:09:55]

Description was changed from

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect

BUG=678023
==========

to

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].
And DOMRectInit is added[2].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect
[2] https://drafts.fxtf.org/geometry/#dictdef-domrectinit

BUG=678023
==========

[Byoungkwon Ko, 2017-01-11 18:12:01]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 18:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-01-11 18:12:51]

gogag2@gmail.com changed reviewers:
+ jinho.bang@samsung.com

[zino, 2017-01-11 18:43:35]

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
(right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html:119:
assert_dom_rect_equals(rect, [10, 20, 80, 50, 20, 90, 70, 10]);
How can we know which this is DOMRect or DOMRectReadOnly?

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/BUILD.gn (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/BUILD.gn:32:
"$blink_core_output_dir/dom/DOMRectInit.cpp",
nit: Please keep alphabetical order.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/core_idl_files.gni (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/core_idl_files.gni:513: "dom/DOMRectInit.idl",
nit: Please keep alphabetical order.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMRect.cpp (left):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMRect.cpp:6: 
nit: Please remove unncessary blank line.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMRectInit.idl (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMRectInit.idl:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
nit: Should be 2017

[commit-bot: I haz the power, 2017-01-11 19:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:00:19]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Byoungkwon Ko, 2017-01-12 17:23:33]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 17:24:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-01-12 17:24:17]

PTAL

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
(right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html:119:
assert_dom_rect_equals(rect, [10, 20, 80, 50, 20, 90, 70, 10]);
On 2017/01/11 18:43:35, zino wrote:
> How can we know which this is DOMRect or DOMRectReadOnly?

I added one more test function to check whether it is DOMRectReadOnly or not.
Plz check it.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/BUILD.gn (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/BUILD.gn:32:
"$blink_core_output_dir/dom/DOMRectInit.cpp",
On 2017/01/11 18:43:35, zino wrote:
> nit: Please keep alphabetical order.

Done.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/core_idl_files.gni (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/core_idl_files.gni:513: "dom/DOMRectInit.idl",
On 2017/01/11 18:43:35, zino wrote:
> nit: Please keep alphabetical order.

Done.

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMRect.cpp (left):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMRect.cpp:6: 
On 2017/01/11 18:43:35, zino wrote:
> nit: Please remove unncessary blank line.

As I know, we need to blank after DOMRect.h.
Am I wrong?

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMRectInit.idl (right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMRectInit.idl:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2017/01/11 18:43:35, zino wrote:
> nit: Should be 2017

Done.

[Byoungkwon Ko, 2017-01-12 17:47:28]

PTAL

[zino, 2017-01-12 19:05:25]

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
(right):

https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html:119:
assert_dom_rect_equals(rect, [10, 20, 80, 50, 20, 90, 70, 10]);
On 2017/01/12 17:24:17, Byoungkwon Ko wrote:
> On 2017/01/11 18:43:35, zino wrote:
> > How can we know which this is DOMRect or DOMRectReadOnly?
> 
> I added one more test function to check whether it is DOMRectReadOnly or not.
> Plz check it.

Sorry for the confused explanation.

DOMRect is DOMRectReadOnly but DOMRectReadOnly is *not* DOMRect.
So, we should check whether the properties are readonly or not.
Also, I think we should check weather the fromRect returns DOMRect or
DOMRectReadOnly.

[commit-bot: I haz the power, 2017-01-12 19:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:19:59]

Dry run: This issue passed the CQ dry run.

[Byoungkwon Ko, 2017-01-14 13:41:31]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 13:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-01-14 13:42:42]

On 2017/01/12 19:05:25, zino wrote:
>
https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
> (right):
> 
>
https://codereview.chromium.org/2612263002/diff/80001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html:119:
> assert_dom_rect_equals(rect, [10, 20, 80, 50, 20, 90, 70, 10]);
> On 2017/01/12 17:24:17, Byoungkwon Ko wrote:
> > On 2017/01/11 18:43:35, zino wrote:
> > > How can we know which this is DOMRect or DOMRectReadOnly?
> > 
> > I added one more test function to check whether it is DOMRectReadOnly or
not.
> > Plz check it.
> 
> Sorry for the confused explanation.
> 
> DOMRect is DOMRectReadOnly but DOMRectReadOnly is *not* DOMRect.
> So, we should check whether the properties are readonly or not.
> Also, I think we should check weather the fromRect returns DOMRect or
> DOMRectReadOnly.

I added more test for checking it is DOMRect or DOMRectReadOnly.
PTAL, and thanks for your review.

[commit-bot: I haz the power, 2017-01-14 15:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 15:49:41]

Dry run: This issue passed the CQ dry run.

[zino, 2017-01-14 17:11:34]

lgtm but please fix nits before adding a reviewer for core directory.

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DOMRect.cpp (right):

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRect.cpp:6: 
nit: Please remove this line?

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRect.cpp:16: return new DOMRect(other.x(),
other.y(), other.width(), other.height());
nit: Please remove unnecessary blanks.

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp (right):

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp:34: return new
DOMRectReadOnly(other.x(), other.y(), other.width(), other.height());
nit: Please remove unnecessary blanks.

[Byoungkwon Ko, 2017-01-15 02:49:08]

gogag2@gmail.com changed reviewers:
+ haraken@chromium.org

[Byoungkwon Ko, 2017-01-15 02:49:09]

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DOMRect.cpp (right):

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRect.cpp:16: return new DOMRect(other.x(),
other.y(), other.width(), other.height());
On 2017/01/14 17:11:33, zino wrote:
> nit: Please remove unnecessary blanks.

Done.

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp (right):

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp:34: return new
DOMRectReadOnly(other.x(), other.y(), other.width(), other.height());
On 2017/01/14 17:11:34, zino wrote:
> nit: Please remove unnecessary blanks.

Done.

[Byoungkwon Ko, 2017-01-15 02:50:23]

PTAL

[Byoungkwon Ko, 2017-01-15 03:00:39]

PTAL

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DOMRect.cpp (right):

https://codereview.chromium.org/2612263002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DOMRect.cpp:6: 
On 2017/01/14 17:11:33, zino wrote:
> nit: Please remove this line?

This is primary header.
Plz take a look again.
Thanks.

[haraken, 2017-01-15 23:44:39]

LGTM

[Byoungkwon Ko, 2017-01-16 11:14:32]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2017-01-16 11:14:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2612263002/#ps160001
(title: "Adding fromRect to DOMRect and DOMRectReadOnly interfaces following
spec.")

[commit-bot: I haz the power, 2017-01-16 11:14:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484565272155610,
"parent_rev": "fd870526d2ed5a6b3577b46aa9f01532b15bc6d5", "commit_rev":
"5be3a2ab80dff22d41a0a5e99a586272208dac37"}

[commit-bot: I haz the power, 2017-01-16 12:49:35]

Description was changed from

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].
And DOMRectInit is added[2].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect
[2] https://drafts.fxtf.org/geometry/#dictdef-domrectinit

BUG=678023
==========

to

==========
Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].
And DOMRectInit is added[2].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect
[2] https://drafts.fxtf.org/geometry/#dictdef-domrectinit

BUG=678023

Review-Url: https://codereview.chromium.org/2612263002
Cr-Commit-Position: refs/heads/master@{#443878}
Committed:
https://chromium.googlesource.com/chromium/src/+/5be3a2ab80dff22d41a0a5e99a58...
==========

[commit-bot: I haz the power, 2017-01-16 12:49:36]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5be3a2ab80dff22d41a0a5e99a58...