Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMRect.cpp

Issue 2612263002: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. (Closed)
Patch Set: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/DOMRect.h" 5 #include "core/dom/DOMRect.h"
6 6
zino 2017/01/14 17:11:33 nit: Please remove this line?
Byoungkwon Ko 2017/01/15 03:00:39 This is primary header. Plz take a look again. Tha
7 #include "core/dom/DOMRectInit.h"
8
7 namespace blink { 9 namespace blink {
8 10
9 DOMRect* DOMRect::create(double x, double y, double width, double height) { 11 DOMRect* DOMRect::create(double x, double y, double width, double height) {
10 return new DOMRect(x, y, width, height); 12 return new DOMRect(x, y, width, height);
11 } 13 }
12 14
15 DOMRect* DOMRect::fromRect(const DOMRectInit& other) {
16 return new DOMRect(other.x(), other.y(), other.width(), other.height());
zino 2017/01/14 17:11:33 nit: Please remove unnecessary blanks.
Byoungkwon Ko 2017/01/15 02:49:08 Done.
17 }
18
13 DOMRect::DOMRect(double x, double y, double width, double height) 19 DOMRect::DOMRect(double x, double y, double width, double height)
14 : DOMRectReadOnly(x, y, width, height) {} 20 : DOMRectReadOnly(x, y, width, height) {}
15 21
16 } // namespace blink 22 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698