Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2612243005: Add postscript path (Closed)

Created:
3 years, 11 months ago by rbpotter
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add postscript path This patch adds the additional functions required to make postscript printing functional. The most significant additions are are two added compression functions and a new API for setting the postscript level. Not currently called from Chromium, Chromium patch to come. BUG= Review-Url: https://codereview.chromium.org/2612243005 Committed: https://pdfium.googlesource.com/pdfium/+/db7647083d0a5cd2221b94faa15c149214d21725

Patch Set 1 #

Patch Set 2 : Small fixes, add comments #

Total comments: 31

Patch Set 3 : Add tests and clean up #

Total comments: 10

Patch Set 4 : Fixes #

Patch Set 5 : Add fuzzers and fix unit tests #

Total comments: 2

Patch Set 6 : Simplify size comparisons in unit tests #

Patch Set 7 : Rebase #

Patch Set 8 : Fix memory leaks in tests #

Patch Set 9 : Get rid of extra declarations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -60 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 2 3 2 chunks +140 lines, -2 lines 0 comments Download
A core/fxcodec/codec/fx_codec_a85_unittest.cpp View 1 2 3 4 5 6 7 1 chunk +209 lines, -0 lines 0 comments Download
A core/fxcodec/codec/fx_codec_rle_unittest.cpp View 1 2 3 4 5 6 7 1 chunk +195 lines, -0 lines 0 comments Download
M core/fxge/cfx_windowsdevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/win32/cfx_psrenderer.cpp View 1 2 3 4 5 6 13 chunks +36 lines, -42 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 2 3 chunks +11 lines, -7 lines 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M public/fpdfview.h View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_a85_fuzzer.cc View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_rle_fuzzer.cc View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (22 generated)
rbpotter
This is the second chunk of the postscript printing code (new additions to enable different ...
3 years, 11 months ago (2017-01-09 19:47:51 UTC) #3
Tom Sepez
https://codereview.chromium.org/2612243005/diff/20001/core/fxcodec/codec/ccodec_basicmodule.h File core/fxcodec/codec/ccodec_basicmodule.h (right): https://codereview.chromium.org/2612243005/diff/20001/core/fxcodec/codec/ccodec_basicmodule.h#newcode18 core/fxcodec/codec/ccodec_basicmodule.h:18: bool RunLengthEncode(const uint8_t* src_buf, Can we add unit_tests and/or ...
3 years, 11 months ago (2017-01-09 20:18:20 UTC) #4
rbpotter
Made changes and added unit tests for the encoding functions. I will look into fuzzers ...
3 years, 11 months ago (2017-01-10 20:28:24 UTC) #5
Tom Sepez
I like your tests. https://codereview.chromium.org/2612243005/diff/20001/core/fxcodec/codec/fx_codec.cpp File core/fxcodec/codec/fx_codec.cpp (right): https://codereview.chromium.org/2612243005/diff/20001/core/fxcodec/codec/fx_codec.cpp#newcode203 core/fxcodec/codec/fx_codec.cpp:203: uint64_t val = (uint64_t)(src_buf[pos]) * ...
3 years, 11 months ago (2017-01-10 21:08:42 UTC) #6
rbpotter
Added fuzzers. Let me know if I missed something when writing them. Also fixed comments ...
3 years, 11 months ago (2017-01-11 20:34:50 UTC) #7
Tom Sepez
Correct, the only way to build the fuzzers is part of a chromium checkout, not ...
3 years, 11 months ago (2017-01-11 21:09:08 UTC) #8
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-11 21:09:18 UTC) #9
rbpotter
Think this is ready to land. Let me know if there are any remaining issues. ...
3 years, 11 months ago (2017-01-11 22:56:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612243005/160001
3 years, 11 months ago (2017-01-12 18:31:29 UTC) #29
commit-bot: I haz the power
Committed patchset #9 (id:160001) as https://pdfium.googlesource.com/pdfium/+/db7647083d0a5cd2221b94faa15c149214d21725
3 years, 11 months ago (2017-01-12 18:31:48 UTC) #32
Lei Zhang
3 years, 10 months ago (2017-02-25 02:01:26 UTC) #33
Message was sent while issue was closed.
On 2017/01/11 21:09:08, Tom Sepez wrote:
> Correct, the only way to build the fuzzers is part of a chromium checkout, not
a
> standalone checkout.  Changing this would require pulling a lot of custom
stuff
> into the pdfium checkouts ...

Though we do build the fuzzer .cc files, because we had too many PDFium DEPS
roll failures when we didn't. See https://codereview.chromium.org/2481933003

Powered by Google App Engine
This is Rietveld 408576698