Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2481933003: Compile fuzzer sources in standalone builds. (try 2) (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Compile fuzzer sources in standalone builds. (try 2) - Add a template for fuzzers to remove redundancy. - Sort fuzzers in alphabetical order. Previous attempt: https://codereview.chromium.org/2480043002/ Committed: https://pdfium.googlesource.com/pdfium/+/62114cf3d85ee9149b270e02935c98395567f45e

Patch Set 1 : Previous attempt #

Patch Set 2 : rebase #

Patch Set 3 : Fix signed comparison issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -185 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 2 chunks +49 lines, -176 lines 0 comments Download
M testing/libfuzzer/pdf_fm2js_fuzzer.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M testing/libfuzzer/xfa_codec_fuzzer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Lei Zhang
4 years, 1 month ago (2016-11-08 06:04:58 UTC) #12
Lei Zhang
4 years, 1 month ago (2016-11-08 18:41:56 UTC) #14
dsinclair
lgtm
4 years, 1 month ago (2016-11-08 20:59:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481933003/40001
4 years, 1 month ago (2016-11-08 20:59:12 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 20:59:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/62114cf3d85ee9149b270e02935c98395567...

Powered by Google App Engine
This is Rietveld 408576698