Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2612103004: [ng_layout] Rename NGFragmentBase,NGFragment,NGPhysicalFragment (Closed)

Created:
3 years, 11 months ago by atotic
Modified:
3 years, 11 months ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames NGPhysicalFragmentBase => NGPhysicalFragment NGPhysicalFragment => NGPhysicalBoxFragment NGFragmentBase => NGFragment NGFragment => NGBoxFragment Suggested by Morten. Thanks to Eclipse for refactoring tools. BUG=635619 Review-Url: https://codereview.chromium.org/2612103004 Cr-Commit-Position: refs/heads/master@{#441807} Committed: https://chromium.googlesource.com/chromium/src/+/2b91b28e0b5fcf099eba2e5b804cd82047c79642

Patch Set 1 #

Total comments: 5

Patch Set 2 : CR: rename ifdef guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -545 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 12 chunks +17 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 18 chunks +45 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 1 chunk +37 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.cc View 1 chunk +40 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_legacy_block_layout_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_legacy_block_layout_algorithm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h View 1 2 chunks +14 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 1 chunk +75 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +30 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
atotic
3 years, 11 months ago (2017-01-05 22:01:56 UTC) #3
cbiesinger
lgtm https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h File third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h (right): https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h#newcode5 third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h:5: #ifndef NGFragment_h NGBoxFragment_h https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_fragment.h File third_party/WebKit/Source/core/layout/ng/ng_fragment.h (right): https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_fragment.h#newcode5 ...
3 years, 11 months ago (2017-01-05 22:06:50 UTC) #4
atotic
CR fixed, checking in. https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h File third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h (right): https://codereview.chromium.org/2612103004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h#newcode5 third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h:5: #ifndef NGFragment_h On 2017/01/05 at ...
3 years, 11 months ago (2017-01-05 22:14:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612103004/20001
3 years, 11 months ago (2017-01-05 22:14:51 UTC) #8
eae
LGTM
3 years, 11 months ago (2017-01-05 22:57:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2b91b28e0b5fcf099eba2e5b804cd82047c79642
3 years, 11 months ago (2017-01-06 01:51:35 UTC) #12
mstensho (USE GERRIT)
3 years, 11 months ago (2017-01-06 09:33:05 UTC) #13
Message was sent while issue was closed.
Thanks for doing this!

Powered by Google App Engine
This is Rietveld 408576698