Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2612103002: Enable several completion tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable several completion tests with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/20ca3e9b7e4ccff712d33db4db9b1d51e764d925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -162 lines) Patch
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 3 chunks +6 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 3 chunks +6 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-04 21:07:12 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-04 21:16:07 UTC) #2
scheglov
3 years, 11 months ago (2017-01-04 22:23:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20ca3e9b7e4ccff712d33db4db9b1d51e764d925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698