Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart

Issue 2612103002: Enable several completion tests with the new analysis driver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart
index 9b6a1d727db82c2fd22e649d1d07e9d8f61f741a..e938523f8f27ede527ffac39a5e6aba0c9804a36 100644
--- a/pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart
@@ -61,7 +61,9 @@ class NamedConstructorContributorTest extends DartCompletionContributorTest {
var m;
main() {new X.^}''');
// Assume that imported libraries are resolved
- await resolveLibraryUnit(libSource);
+ if (!enableNewAnalysisDriver) {
+ await resolveLibraryUnit(libSource);
+ }
await computeSuggestions();
expect(replacementOffset, completionOffset);
expect(replacementLength, 0);
@@ -115,7 +117,9 @@ class NamedConstructorContributorTest extends DartCompletionContributorTest {
var m;
main() {new X.^}''');
// Assume that imported libraries are resolved
- await resolveLibraryUnit(libSource);
+ if (!enableNewAnalysisDriver) {
+ await resolveLibraryUnit(libSource);
+ }
await computeSuggestions();
expect(replacementOffset, completionOffset);
expect(replacementLength, 0);
@@ -187,18 +191,4 @@ class NamedConstructorContributorTest_Driver
extends NamedConstructorContributorTest {
@override
bool get enableNewAnalysisDriver => true;
-
- @failingTest
- @override
- test_ConstructorName_importedClass() {
-// Bad state: Should not be used with the new analysis driver.
- return super.test_ConstructorName_importedClass();
- }
-
- @failingTest
- @override
- test_ConstructorName_importedFactory() {
-// Bad state: Should not be used with the new analysis driver.
- return super.test_ConstructorName_importedFactory();
- }
}

Powered by Google App Engine
This is Rietveld 408576698