Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

Issue 2612103002: Enable several completion tests with the new analysis driver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
index 3ce88ef2e11a368ef5858d9c3d3b0f1b8adb7e70..4290b2f00b7d01e36bb12d3991aba6dc1de00f10 100644
--- a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
@@ -65,7 +65,9 @@ class CombinatorContributorTest extends DartCompletionContributorTest {
class X {}''');
// Assume that imported libraries have been resolved
- context.resolveCompilationUnit2(importedLibSource, importedLibSource);
+ if (!enableNewAnalysisDriver) {
+ context.resolveCompilationUnit2(importedLibSource, importedLibSource);
+ }
await computeSuggestions();
assertSuggestClass('A',
@@ -117,7 +119,9 @@ class CombinatorContributorTest extends DartCompletionContributorTest {
class X {}''');
// Assume that imported libraries have been resolved
- context.resolveCompilationUnit2(importedLibSource, importedLibSource);
+ if (!enableNewAnalysisDriver) {
+ context.resolveCompilationUnit2(importedLibSource, importedLibSource);
+ }
await computeSuggestions();
assertSuggestClass('A',
@@ -157,18 +161,4 @@ class CombinatorContributorTest extends DartCompletionContributorTest {
class CombinatorContributorTest_Driver extends CombinatorContributorTest {
@override
bool get enableNewAnalysisDriver => true;
-
- @failingTest
- @override
- test_Combinator_hide() {
-// Bad state: Should not be used with the new analysis driver.
- return super.test_Combinator_hide();
- }
-
- @failingTest
- @override
- test_Combinator_show() {
-// Bad state: Should not be used with the new analysis driver.
- return super.test_Combinator_show();
- }
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698