SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
Review-Url: https://codereview.chromium.org/2612043004
Cr-Commit-Position: refs/heads/master@{#442527}
Committed: https://chromium.googlesource.com/chromium/src/+/e1333fa774f8efbe7833ee19618a120c1135bc99

[nhiroki, 2017-01-05 10:22:21]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 10:22:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 11:27:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 11:27:22]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-01-05 23:32:22]

Description was changed from

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is only message type that uses this mechanism, and (2) the
connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
==========

to

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the
connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
==========

[nhiroki, 2017-01-05 23:32:32]

Description was changed from

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the
connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
==========

to

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
==========

[nhiroki, 2017-01-06 03:15:47]

nhiroki@chromium.org changed reviewers:
+ horo@chromium.org, kinuko@chromium.org

[nhiroki, 2017-01-06 03:15:48]

PTAL.

This cleanup is helpful for my mojofication CL:
https://codereview.chromium.org/2600113003/

[nhiroki, 2017-01-06 03:16:03]

Patchset #1 (id:1) has been deleted

[horo, 2017-01-06 06:59:45]

lgtm with a nit

https://codereview.chromium.org/2612043004/diff/20001/content/renderer/websha...
File content/renderer/websharedworker_proxy.cc (right):

https://codereview.chromium.org/2612043004/diff/20001/content/renderer/websha...
content/renderer/websharedworker_proxy.cc:31: ConnectListener* listener) {
DCHECK_EQ(MSG_ROUTING_NONE, message_port_id_);

[nhiroki, 2017-01-06 07:20:47]

Thank you.

https://codereview.chromium.org/2612043004/diff/20001/content/renderer/websha...
File content/renderer/websharedworker_proxy.cc (right):

https://codereview.chromium.org/2612043004/diff/20001/content/renderer/websha...
content/renderer/websharedworker_proxy.cc:31: ConnectListener* listener) {
On 2017/01/06 06:59:45, horo wrote:
> DCHECK_EQ(MSG_ROUTING_NONE, message_port_id_);

Done.

[nhiroki, 2017-01-06 07:21:08]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 07:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 08:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 08:26:08]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-01-07 02:24:12]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-07 02:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2612043004/#ps40001
(title: "add DCHECK")

[commit-bot: I haz the power, 2017-01-07 02:24:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:31:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nhiroki, 2017-01-10 02:21:24]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-10 02:21:33]

The CQ bit was unchecked by nhiroki@chromium.org

[kinuko, 2017-01-10 05:19:48]

lgtm

[nhiroki, 2017-01-10 05:25:50]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:26:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:54:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484025950877500,
"parent_rev": "4129cc4b6d03ba0b81c43bc5a682f13c6e14817c", "commit_rev":
"e1333fa774f8efbe7833ee19618a120c1135bc99"}

[commit-bot: I haz the power, 2017-01-10 07:55:21]

Description was changed from

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308
==========

to

==========
SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy

This is just a cleanup and should not change behavior.

WebSharedWorkerProxy has a message queueing mechanism to delay sending messages
until a shared worker is created. This mechanism can handle any message types
and any number of messages, but this would be an overkill. This is because (1)
a connection request is the only message type that uses this mechanism, and (2)
the connection request is issued only one time.

In addition, the current implementation checks |created_| flag on Send() but
this is always false when it's initially called from connect() because a worker
creation request is sent immediately before connect() call.

This CL makes WebSharedWorkerProxy hold only one pending request and removes the
unnecessary |created_| check for cleanup.

BUG=612308

Review-Url: https://codereview.chromium.org/2612043004
Cr-Commit-Position: refs/heads/master@{#442527}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1333fa774f8efbe7833ee19618a...
==========

[commit-bot: I haz the power, 2017-01-10 07:55:23]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e1333fa774f8efbe7833ee19618a...