Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/renderer/websharedworker_proxy.h

Issue 2612043004: SharedWorker: Simplify message queueing mechanism in WebSharedWorkerProxy (Closed)
Patch Set: add DCHECK Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/websharedworker_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/websharedworker_proxy.h
diff --git a/content/renderer/websharedworker_proxy.h b/content/renderer/websharedworker_proxy.h
index 9c854469bf3910ccd0888c7a06916e56e3bf6631..1aaaf9def92280ce9d6f90977757704375a70a61 100644
--- a/content/renderer/websharedworker_proxy.h
+++ b/content/renderer/websharedworker_proxy.h
@@ -12,7 +12,6 @@
#include "base/macros.h"
#include "ipc/ipc_listener.h"
#include "third_party/WebKit/public/web/WebSharedWorkerConnector.h"
-#include "url/gurl.h"
namespace IPC {
class MessageRouter;
@@ -39,13 +38,6 @@ class WebSharedWorkerProxy : public blink::WebSharedWorkerConnector,
// IPC::Listener implementation.
bool OnMessageReceived(const IPC::Message& message) override;
- // Sends a message to the worker thread (forwarded via the RenderViewHost).
- // If WorkerStarted() has not yet been called, message is queued.
- bool Send(std::unique_ptr<IPC::Message> message);
-
- // Sends any messages currently in the queue.
- void SendQueuedMessages();
-
void OnWorkerCreated();
void OnWorkerScriptLoadFailed();
void OnWorkerConnected();
@@ -58,11 +50,8 @@ class WebSharedWorkerProxy : public blink::WebSharedWorkerConnector,
IPC::MessageRouter* const router_;
- // Stores messages that were sent before the StartWorkerContext message.
- std::vector<std::unique_ptr<IPC::Message>> queued_messages_;
-
+ int message_port_id_;
ConnectListener* connect_listener_;
- bool created_;
DISALLOW_COPY_AND_ASSIGN(WebSharedWorkerProxy);
};
« no previous file with comments | « no previous file | content/renderer/websharedworker_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698