Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2611943004: Disable UserInputTracker DCHECK which is firing in unit tests. (Closed)

Created:
3 years, 11 months ago by Bryan McQuade
Modified:
3 years, 11 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable UserInputTracker DCHECK which is firing in unit tests. UserInputTracker::OnInputEvent has a DCHECK to make sure that any WebInputEvent received has a timeStampSeconds that isn't in the future. The dcheck only fires in cases where we have a high resolution clock, as high resolution clocks are guaranteed to be system-wide monotonic across all processes (whereas the windows non-high res monotonic clock can skew between processes). This dcheck recently started firing in unit tests. For now, we just disable the dcheck since the broken tests is causing issues for other devs, but the real fix is to figure out why the input events have timestamps in the future and fix that. BUG=678093 Review-Url: https://codereview.chromium.org/2611943004 Cr-Commit-Position: refs/heads/master@{#441664} Committed: https://chromium.googlesource.com/chromium/src/+/ec1a7d3712848ad33ca4adf21950877624d44ee0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/page_load_metrics/user_input_tracker.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Bryan McQuade
PTAL. The commit queue is apparently borked until this lands, so we need to disable ...
3 years, 11 months ago (2017-01-05 15:15:51 UTC) #4
Charlie Harrison
lgtm
3 years, 11 months ago (2017-01-05 15:22:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611943004/1
3 years, 11 months ago (2017-01-05 16:00:19 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 16:06:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec1a7d3712848ad33ca4adf21950...

Powered by Google App Engine
This is Rietveld 408576698