Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6529)

Unified Diff: chrome/browser/page_load_metrics/user_input_tracker.cc

Issue 2611943004: Disable UserInputTracker DCHECK which is firing in unit tests. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/user_input_tracker.cc
diff --git a/chrome/browser/page_load_metrics/user_input_tracker.cc b/chrome/browser/page_load_metrics/user_input_tracker.cc
index c72b94e9da037b970a1f2b46efef57a73afa949e..c21ff1c15b6fb7ae432837075f377b63d1072a20 100644
--- a/chrome/browser/page_load_metrics/user_input_tracker.cc
+++ b/chrome/browser/page_load_metrics/user_input_tracker.cc
@@ -99,7 +99,12 @@ void UserInputTracker::OnInputEvent(const blink::WebInputEvent& event) {
return;
if (time > now) {
- DCHECK(!base::TimeTicks::IsHighResolution());
+ // We should never receive a UserInputEvent with a timestamp in the future
+ // if we're on a platform with a high-res clock, where the monotonic clock
+ // is system-wide monotonic. Unfortunately, this DCHECK seems to fire in
+ // some linux unit tests, so it is disabled for the time being. See
+ // crbug.com/678093 for more details.
+ // DCHECK(!base::TimeTicks::IsHighResolution());
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698