Allow top-level frames to request any USB device.

Allow top-level frames to request any USB device.

This patch changes the rules for WebUSB so that a top level frame can
request access to any USB device, while embedded frames must have an
origin matching the allowed origins structure read from the device.

Integration tests for WebUSB are added which exercise this.

BUG=492204
Review-Url: https://codereview.chromium.org/2611773004
Cr-Commit-Position: refs/heads/master@{#442105}
Committed: https://chromium.googlesource.com/chromium/src/+/d890f99cb3e60ad71c087b4d9a628c0c400aa196

[Reilly Grant (use Gerrit), 2017-01-03 23:58:49]

reillyg@chromium.org changed reviewers:
+ pkasting@chromium.org, scheib@chromium.org

[Reilly Grant (use Gerrit), 2017-01-03 23:58:49]

pkasting@, please review chrome/browser/ui/startup/bad_flags_prompt.cc
scheib@, please review everything else.

[Reilly Grant (use Gerrit), 2017-01-03 23:58:53]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:59:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:38:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-01-04 00:48:03]

Fix unit_tests compile.

[Reilly Grant (use Gerrit), 2017-01-04 00:48:10]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:48:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:35:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2017-01-04 19:06:03]

LGTM, comments suggested:

https://codereview.chromium.org/2611773004/diff/20001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_browsertest.cc (right):

https://codereview.chromium.org/2611773004/diff/20001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_browsertest.cc:101: device_client_.reset(new
MockDeviceClient());
Add some comments here, and in the last test, highlighting how fake devices are
setup and how the test is using them to validate the origin restriction. --
it'll make it much easier to parse and understand later.

[Reilly Grant (use Gerrit), 2017-01-04 21:03:44]

Fix ExtensionPrinterHandlerTest.GetUsbPrinters

[Reilly Grant (use Gerrit), 2017-01-04 21:16:36]

Add comments explaining how the mock devices are being used.

[Reilly Grant (use Gerrit), 2017-01-04 21:19:56]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:20:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:28:14]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-01-06 02:28:04]

LGTM

[Reilly Grant (use Gerrit), 2017-01-06 16:49:09]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-01-06 16:49:09]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2611773004/#ps60001
(title: "Add comments explaining how the mock devices are being used.")

[commit-bot: I haz the power, 2017-01-06 16:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 18:40:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:40:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Reilly Grant (use Gerrit), 2017-01-07 00:13:06]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-01-07 00:13:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:18:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483747986311590,
"parent_rev": "0d5d318987dde8b60ca474976128c5543b2e2563", "commit_rev":
"d890f99cb3e60ad71c087b4d9a628c0c400aa196"}

[commit-bot: I haz the power, 2017-01-07 00:18:56]

Description was changed from

==========
Allow top-level frames to request any USB device.

This patch changes the rules for WebUSB so that a top level frame can
request access to any USB device, while embedded frames must have an
origin matching the allowed origins structure read from the device.

Integration tests for WebUSB are added which exercise this.

BUG=492204
==========

to

==========
Allow top-level frames to request any USB device.

This patch changes the rules for WebUSB so that a top level frame can
request access to any USB device, while embedded frames must have an
origin matching the allowed origins structure read from the device.

Integration tests for WebUSB are added which exercise this.

BUG=492204

Review-Url: https://codereview.chromium.org/2611773004
Cr-Commit-Position: refs/heads/master@{#442105}
Committed:
https://chromium.googlesource.com/chromium/src/+/d890f99cb3e60ad71c087b4d9a62...
==========

[commit-bot: I haz the power, 2017-01-07 00:18:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d890f99cb3e60ad71c087b4d9a62...