chrome/browser/usb/web_usb_chooser_service.cc - Issue 2611773004: Allow top-level frames to request any USB device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/web_usb_chooser_service.cc

Issue 2611773004: Allow top-level frames to request any USB device. (Closed)

Patch Set: Add comments explaining how the mock devices are being used. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/usb/web_usb_chooser_service.cc

diff --git a/chrome/browser/usb/web_usb_chooser_service.cc b/chrome/browser/usb/web_usb_chooser_service.cc

index fd3a15e168dfd5d1670bcbaaf397d13c9df3fa64..851cb6bf9b47844068c4a529960ec6bc3172c8de 100644

--- a/chrome/browser/usb/web_usb_chooser_service.cc

+++ b/chrome/browser/usb/web_usb_chooser_service.cc

@@ -36,7 +36,7 @@ void WebUsbChooserService::GetPermission(

Browser* browser = chrome::FindBrowserWithWebContents(web_contents);

std::unique_ptr<UsbChooserController> usb_chooser_controller(

new UsbChooserController(render_frame_host_, std::move(device_filters),

- render_frame_host_, callback));

+ callback));

std::unique_ptr<ChooserBubbleDelegate> chooser_bubble_delegate(

new ChooserBubbleDelegate(render_frame_host_,

std::move(usb_chooser_controller)));