Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2611723002: Moved http_client_appengine.py from ./common to ./gae_libs/http (Closed)

Created:
3 years, 11 months ago by wrengr
Modified:
3 years, 11 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : removed extraneous dependency #

Patch Set 3 : adding missing __init__.py file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -176 lines) Patch
D appengine/findit/common/auth_util.py View 1 chunk +0 lines, -37 lines 0 comments Download
M appengine/findit/common/base_handler.py View 1 chunk +1 line, -1 line 0 comments Download
D appengine/findit/common/http_client_appengine.py View 1 chunk +0 lines, -74 lines 0 comments Download
M appengine/findit/common/test/chrome_dependency_fetcher_test.py View 1 chunk +3 lines, -2 lines 0 comments Download
M appengine/findit/common/waterfall/buildbucket_client.py View 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/findit/crash/crash_pipeline.py View 2 chunks +3 lines, -4 lines 0 comments Download
M appengine/findit/crash/test/findit_for_chromecrash_test.py View 2 chunks +1 line, -1 line 0 comments Download
M appengine/findit/findit_api.py View 2 chunks +2 lines, -2 lines 0 comments Download
A appengine/findit/gae_libs/http/__init__.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + appengine/findit/gae_libs/http/auth_util.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/gae_libs/http/http_client_appengine.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/gae_libs/testcase.py View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/findit/handlers/crash/crash_handler.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/flake/check_flake.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/help_triage.py View 2 chunks +3 lines, -2 lines 0 comments Download
M appengine/findit/handlers/monitor_alerts.py View 1 chunk +3 lines, -2 lines 0 comments Download
M appengine/findit/handlers/process_failure_analysis_requests.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/test/monitor_alerts_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/infra_api_clients/codereview/rietveld.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/build_failure_analysis.py View 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/build_util.py View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/detect_first_failure_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/extract_deps_info_pipeline.py View 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/findit/waterfall/extract_signal_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/flake/step_mapper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/flake/test/step_mapper_test.py View 3 chunks +5 lines, -4 lines 0 comments Download
M appengine/findit/waterfall/identify_try_job_culprit_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/pull_changelog_pipeline.py View 2 chunks +3 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/send_notification_for_culprit_pipeline.py View 2 chunks +3 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/swarming_util.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py View 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/test/swarming_util_test.py View 8 chunks +8 lines, -8 lines 0 comments Download
M appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
wrengr
This is a dependency for addressing the nits in https://codereview.chromium.org/2605943002/. PTAL
3 years, 11 months ago (2017-01-03 18:36:43 UTC) #3
Sharu Jiang
lgtm
3 years, 11 months ago (2017-01-03 18:53:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611723002/20001
3 years, 11 months ago (2017-01-03 19:00:59 UTC) #6
stgao
lgtm
3 years, 11 months ago (2017-01-03 19:02:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/337e8c3d8a0a8710)
3 years, 11 months ago (2017-01-03 19:13:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611723002/40001
3 years, 11 months ago (2017-01-03 19:33:39 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:44:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/900548fa35745ce1181ea6e48addd...

Powered by Google App Engine
This is Rietveld 408576698