Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: appengine/findit/waterfall/build_failure_analysis.py

Issue 2611723002: Moved http_client_appengine.py from ./common to ./gae_libs/http (Closed)
Patch Set: adding missing __init__.py file Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/infra_api_clients/codereview/rietveld.py ('k') | appengine/findit/waterfall/build_util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/build_failure_analysis.py
diff --git a/appengine/findit/waterfall/build_failure_analysis.py b/appengine/findit/waterfall/build_failure_analysis.py
index 99ae9efeef301c187e4ab88d60eacf67ac3818b3..8d84b34d6820b974fb59af6cfb292dc985c03ba6 100644
--- a/appengine/findit/waterfall/build_failure_analysis.py
+++ b/appengine/findit/waterfall/build_failure_analysis.py
@@ -6,7 +6,7 @@ from collections import defaultdict
import os
import re
-from common.http_client_appengine import HttpClientAppengine as HttpClient
+from gae_libs.http.http_client_appengine import HttpClientAppengine
from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
from libs.gitiles.diff import ChangeType
from waterfall.failure_signal import FailureSignal
@@ -44,7 +44,7 @@ def _GetGitBlame(repo_info, touched_file_path):
"""
if repo_info:
repo_url = repo_info['repo_url']
- git_repo = CachedGitilesRepository(HttpClient(), repo_url)
+ git_repo = CachedGitilesRepository(HttpClientAppengine(), repo_url)
revision = repo_info['revision']
return git_repo.GetBlame(touched_file_path, revision)
@@ -442,7 +442,7 @@ def _GetChangedLinesForDependencyRepo(roll, file_path_in_log, line_numbers):
Tests if the same lines mentioned in failure log are changed within
the DEPS roll, if so, return those line numbers.
"""
- roll_repo = CachedGitilesRepository(HttpClient(), roll['repo_url'])
+ roll_repo = CachedGitilesRepository(HttpClientAppengine(), roll['repo_url'])
old_revision = roll['old_revision']
new_revision = roll['new_revision']
old_change_log = roll_repo.GetChangeLog(old_revision)
« no previous file with comments | « appengine/findit/infra_api_clients/codereview/rietveld.py ('k') | appengine/findit/waterfall/build_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698