Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2611673002: Moves overscroll code out of the ios_internal namespace. (Closed)

Created:
3 years, 11 months ago by rohitrao (ping after 24h)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves overscroll code out of the ios_internal namespace. Most of this CL was automated using the following commands: tools/git/mffr.py -f ios_internal::OverscrollAction OverscrollAction tools/git/mffr.py -f ios_internal::OverscrollState OverscrollState tools/git/mffr.py -f ios_internal::OverscrollStyle OverscrollStyle Also fixes a typo in the overscroll notification names. BUG=677941 Committed: https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1 Cr-Commit-Position: refs/heads/master@{#441120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -108 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +8 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_controller.mm View 2 chunks +6 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h View 5 chunks +5 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm View 18 chunks +33 lines, -39 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h View 4 chunks +2 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm View 10 chunks +32 lines, -34 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
rohitrao (ping after 24h)
3 years, 11 months ago (2017-01-03 13:51:30 UTC) #4
noyau (Ping after 24h)
lgtm (this popped up in my email for some reason, I reviewed it before seeing ...
3 years, 11 months ago (2017-01-03 13:57:17 UTC) #6
sdefresne
On 2017/01/03 13:57:17, noyau (OOO until Jan 2) wrote: > lgtm (this popped up in ...
3 years, 11 months ago (2017-01-03 14:16:05 UTC) #9
sdefresne
lgtm
3 years, 11 months ago (2017-01-03 14:16:46 UTC) #10
noyau (Ping after 24h)
On 2017/01/03 14:16:05, sdefresne wrote: > On 2017/01/03 13:57:17, noyau (OOO until Jan 2) wrote: ...
3 years, 11 months ago (2017-01-03 14:24:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611673002/1
3 years, 11 months ago (2017-01-03 14:26:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 14:31:38 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 14:34:11 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1
Cr-Commit-Position: refs/heads/master@{#441120}

Powered by Google App Engine
This is Rietveld 408576698