[modules] Add an IsModule flag to ScriptOriginOptions.

[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569, v8:5685
Review-Url: https://codereview.chromium.org/2611643002
Cr-Commit-Position: refs/heads/master@{#42490}
Committed: https://chromium.googlesource.com/v8/v8/+/b0f5abbea372b0cc4d27f267de271766f5c8a11a

[neis, 2017-01-03 11:56:12]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 11:56:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2017-01-03 12:05:48]

Description was changed from

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

BUG=v8:1569
==========

to

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation cache, this
ensures that the cache never confuses a module with a non-module script.

BUG=v8:1569
==========

[neis, 2017-01-03 12:05:48]

neis@chromium.org changed reviewers:
+ adamk@chromium.org, mstarzinger@chromium.org

[neis, 2017-01-03 12:06:02]

Description was changed from

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation cache, this
ensures that the cache never confuses a module with a non-module script.

BUG=v8:1569
==========

to

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2017-01-03 12:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 12:24:09]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-01-03 18:41:32]

This looks right to me except for the ScriptOrigin::ModuleOrigin helper.

https://codereview.chromium.org/2611643002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2611643002/diff/1/include/v8.h#newcode1009
include/v8.h:1009: V8_INLINE static ScriptOrigin ModuleOrigin(Local<Value>
resource_name,
If we're going to expose this API we probably want to expose all the same bits
that would make sense for a module, which I think is...everything except for
is_wasm? Not that I love that the API here is just a bunch of booleans.

[neis, 2017-01-18 12:13:27]

On 2017/01/03 18:41:32, adamk wrote:
> This looks right to me except for the ScriptOrigin::ModuleOrigin helper.
> 
> https://codereview.chromium.org/2611643002/diff/1/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/2611643002/diff/1/include/v8.h#newcode1009
> include/v8.h:1009: V8_INLINE static ScriptOrigin ModuleOrigin(Local<Value>
> resource_name,
> If we're going to expose this API we probably want to expose all the same bits
> that would make sense for a module, which I think is...everything except for
> is_wasm? Not that I love that the API here is just a bunch of booleans.

I removed the function from the API and instead defined it in test-modules and
inlined it in d8 and bytecode-expectations-printer.

[neis, 2017-01-18 12:13:36]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 12:13:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2017-01-18 12:14:33]

Description was changed from

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569
==========

to

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569,v8:5685
==========

[commit-bot: I haz the power, 2017-01-18 12:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:42:02]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-01-18 17:34:00]

lgtm

[neis, 2017-01-19 06:57:18]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2017-01-19 06:57:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 06:59:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484809038515400,
"parent_rev": "975430161ee1f67b9c21cfaf6129e05cff5a63cf", "commit_rev":
"b0f5abbea372b0cc4d27f267de271766f5c8a11a"}

[commit-bot: I haz the power, 2017-01-19 06:59:26]

Description was changed from

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569,v8:5685
==========

to

==========
[modules] Add an IsModule flag to ScriptOriginOptions.

Since the script origin is part of the key used in the compilation
cache, this ensures that the cache never confuses a module with a
non-module script.

BUG=v8:1569,v8:5685

Review-Url: https://codereview.chromium.org/2611643002
Cr-Commit-Position: refs/heads/master@{#42490}
Committed:
https://chromium.googlesource.com/v8/v8/+/b0f5abbea372b0cc4d27f267de271766f5c...
==========

[commit-bot: I haz the power, 2017-01-19 06:59:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b0f5abbea372b0cc4d27f267de271766f5c...