src/d8.cc - Issue 2611643002: [modules] Add an IsModule flag to ScriptOriginOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 2611643002: [modules] Add an IsModule flag to ScriptOriginOptions. (Closed)

Patch Set: Remove convenience function from API. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 74a0b56e4f7a5ab9232061ed744818e630e1546f..f36e3a1739f0ca666baf2e9d3d442462d2032516 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -694,7 +694,9 @@ MaybeLocal<Module> Shell::FetchModuleTree(Local<Context> context,

}

ScriptOrigin origin(

String::NewFromUtf8(isolate, file_name.c_str(), NewStringType::kNormal)

- .ToLocalChecked());

+ .ToLocalChecked(),

+ Local<Integer>(), Local<Integer>(), Local<Boolean>(), Local<Integer>(),

+ Local<Value>(), Local<Boolean>(), Local<Boolean>(), True(isolate));

ScriptCompiler::Source source(source_text, origin);

Local<Module> module;

if (!ScriptCompiler::CompileModule(isolate, &source).ToLocal(&module)) {

« no previous file with comments | « src/compiler.cc ('k') | src/objects.h » ('j') | no next file with comments »