Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2611623002: Revert of [turbofan] fix another divergence in escape analysis (Closed)

Created:
3 years, 11 months ago by Tobias Tebbi
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] fix another divergence in escape analysis (patchset #1 id:1 of https://codereview.chromium.org/2599793002/ ) Reason for revert: Caused memory corruption. BUG=chromium:676767 Original issue's description: > [turbofan] fix another divergence in escape analysis > > This divergence bug is very similar to the one fixed in https://codereview.chromium.org/2522253002/, this time it is an oscillation between a cleared field and a new phi node. The page http://www.sears.com/clothing-shoes-jewelry-clothing-men-s-clothing-men-s-jeans/b-1325287370?Brand=LEE&filterList=Brand&sortOption=UNITS_HIGH_TO_LOW allows for a reliable reproduction. > > This fix makes sure that once a field that generated a phi gets cleared, it always stays cleared. > > BUG=chromium:670202 > > R=bmeurer@chromium.org > > Review-Url: https://codereview.chromium.org/2599793002 > Cr-Commit-Position: refs/heads/master@{#41922} > Committed: https://chromium.googlesource.com/v8/v8/+/8435cc852672c504d5899cc2765c5b895e658efe TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:670202 Review-Url: https://codereview.chromium.org/2611623002 Cr-Commit-Position: refs/heads/master@{#42023} Committed: https://chromium.googlesource.com/v8/v8/+/e3ac5a31cb645974b02e1d7b238f6a9c35ab0f5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/escape-analysis.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tobias Tebbi
Created Revert of [turbofan] fix another divergence in escape analysis
3 years, 11 months ago (2017-01-03 09:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611623002/1
3 years, 11 months ago (2017-01-03 09:36:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-03 09:36:12 UTC) #5
Benedikt Meurer
LGTM
3 years, 11 months ago (2017-01-03 10:45:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611623002/1
3 years, 11 months ago (2017-01-03 10:47:24 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 11:12:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e3ac5a31cb645974b02e1d7b238f6a9c35a...

Powered by Google App Engine
This is Rietveld 408576698