Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2599793002: [turbofan] fix another divergence in escape analysis (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fix another divergence in escape analysis This divergence bug is very similar to the one fixed in https://codereview.chromium.org/2522253002/, this time it is an oscillation between a cleared field and a new phi node. The page http://www.sears.com/clothing-shoes-jewelry-clothing-men-s-clothing-men-s-jeans/b-1325287370?Brand=LEE&filterList=Brand&sortOption=UNITS_HIGH_TO_LOW allows for a reliable reproduction. This fix makes sure that once a field that generated a phi gets cleared, it always stays cleared. BUG=chromium:670202 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2599793002 Cr-Commit-Position: refs/heads/master@{#41922} Committed: https://chromium.googlesource.com/v8/v8/+/8435cc852672c504d5899cc2765c5b895e658efe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/escape-analysis.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Tebbi
4 years ago (2016-12-22 13:41:58 UTC) #1
Benedikt Meurer
lgtm Woohoo
4 years ago (2016-12-22 13:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599793002/1
4 years ago (2016-12-22 13:56:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/8435cc852672c504d5899cc2765c5b895e658efe
4 years ago (2016-12-22 14:21:32 UTC) #7
Tobias Tebbi
3 years, 11 months ago (2017-01-03 09:36:08 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2611623002/ by tebbi@chromium.org.

The reason for reverting is: Caused memory corruption.

BUG=chromium:676767.

Powered by Google App Engine
This is Rietveld 408576698