Add quic_logging

Add quic_logging.

Merge internal change 143128776

(Please do not revert this change if net/quic/core/congestion_control/rtt_stats_test.cc failed in Android_Cronet_Lollipop_Builder, I will land a fix asap.)

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443626}
Committed: https://chromium.googlesource.com/chromium/src/+/b25a2cd51e7758bf4c4f977cd01b17759e865bbf

[Fan Yang, 2017-01-04 15:48:52]

Description was changed from

==========
add copyright headers.


Add quic_logging.

BUG=
==========

to

==========
Add quic_logging.

Merge internal change 143128776

BUG=
==========

[Fan Yang, 2017-01-04 15:49:17]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 15:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 16:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 16:15:02]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Fan Yang, 2017-01-04 19:48:25]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-01-04 19:49:01]

fayang@chromium.org changed reviewers:
+ rch@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:13:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Ryan Hamilton, 2017-01-05 15:44:55]

https://codereview.chromium.org/2611613003/diff/60001/net/quic/platform/impl/...
File net/quic/platform/impl/quic_logging_impl.h (right):

https://codereview.chromium.org/2611613003/diff/60001/net/quic/platform/impl/...
net/quic/platform/impl/quic_logging_impl.h:12: #define
QUIC_LOG_FIRST_N_IMPL(severity, n) QUIC_DLOG(severity)
I'm confused by these 3 lines. api/logging.h depends on logging_imp.h but not
the other way around. So it's surprising that a definition in impl depends on
QUIC_DLOG() from api. Could this be QUIC_DLOG_IMPL(severity) instead?

[Fan Yang, 2017-01-05 15:52:18]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 15:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-01-05 15:52:40]

On 2017/01/05 15:44:55, Ryan Hamilton wrote:
>
https://codereview.chromium.org/2611613003/diff/60001/net/quic/platform/impl/...
> File net/quic/platform/impl/quic_logging_impl.h (right):
> 
>
https://codereview.chromium.org/2611613003/diff/60001/net/quic/platform/impl/...
> net/quic/platform/impl/quic_logging_impl.h:12: #define
> QUIC_LOG_FIRST_N_IMPL(severity, n) QUIC_DLOG(severity)
> I'm confused by these 3 lines. api/logging.h depends on logging_imp.h but not
> the other way around. So it's surprising that a definition in impl depends on
> QUIC_DLOG() from api. Could this be QUIC_DLOG_IMPL(severity) instead?

Ah, yes, sorry. Done.

[commit-bot: I haz the power, 2017-01-05 16:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:19:33]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Fan Yang, 2017-01-05 18:41:44]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 18:42:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 19:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:47:03]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-01-10 20:37:06]

lgtm

https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
File net/quic/platform/impl/quic_logging_impl.h (right):

https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
net/quic/platform/impl/quic_logging_impl.h:19: #define QUIC_CHROMIUM_LOG_ERROR
LOG(ERROR)
I suspect we want both of these to be DLOG so as to avoid bloating chrome with
strings that are not actually visible.

[Fan Yang, 2017-01-10 20:53:45]

On 2017/01/10 20:37:06, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
> File net/quic/platform/impl/quic_logging_impl.h (right):
> 
>
https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
> net/quic/platform/impl/quic_logging_impl.h:19: #define QUIC_CHROMIUM_LOG_ERROR
> LOG(ERROR)
> I suspect we want both of these to be DLOG so as to avoid bloating chrome with
> strings that are not actually visible.

Do you mean WARNING and ERROR?

[Ryan Hamilton, 2017-01-10 22:49:20]

lgtm

https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
File net/quic/platform/impl/quic_logging_impl.h (right):

https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
net/quic/platform/impl/quic_logging_impl.h:19: #define QUIC_CHROMIUM_LOG_ERROR
LOG(ERROR)
On 2017/01/10 20:37:06, Ryan Hamilton wrote:
> I suspect we want both of these to be DLOG so as to avoid bloating chrome with
> strings that are not actually visible.

Correct.

[Fan Yang, 2017-01-12 20:44:42]

On 2017/01/10 22:49:20, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
> File net/quic/platform/impl/quic_logging_impl.h (right):
> 
>
https://codereview.chromium.org/2611613003/diff/100001/net/quic/platform/impl...
> net/quic/platform/impl/quic_logging_impl.h:19: #define QUIC_CHROMIUM_LOG_ERROR
> LOG(ERROR)
> On 2017/01/10 20:37:06, Ryan Hamilton wrote:
> > I suspect we want both of these to be DLOG so as to avoid bloating chrome
with
> > strings that are not actually visible.
> 
> Correct.

Done. Thanks a lot, Ryan.

[Fan Yang, 2017-01-12 20:44:47]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:42:26]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2017-01-12 22:46:16]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2017-01-12 22:46:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2611613003/#ps160001
(title: "add mis-deleted includes")

[commit-bot: I haz the power, 2017-01-12 22:46:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:40:05]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484261176355930,
"parent_rev": "e1723556c1c6ab404ab7e327c4cc62f19001aa51", "commit_rev":
"955b101f8b2f8f1e1db8d80cbac4c3519504ec39"}

[commit-bot: I haz the power, 2017-01-13 00:40:45]

Description was changed from

==========
Add quic_logging.

Merge internal change 143128776

BUG=
==========

to

==========
Add quic_logging.

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}
Committed:
https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4...
==========

[commit-bot: I haz the power, 2017-01-13 00:40:46]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4...

[findit-for-me, 2017-01-13 02:20:40]

FYI: Findit identified this CL at revision 443413 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[mikecase (-- gone --), 2017-01-13 02:24:45]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2629723003/ by mikecase@chromium.org.

The reason for reverting is: Sheriff: Suspect CL for causing net_unittest
failures on several bots such as
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cr....

[mikecase (-- gone --), 2017-01-13 02:24:54]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2631613002/ by mikecase@chromium.org.

The reason for reverting is: Sheriff: Suspect CL for causing net_unittest
failures on several bots such as
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cr....

[Fan Yang, 2017-01-13 14:48:35]

Description was changed from

==========
Add quic_logging.

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}
Committed:
https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4...
==========

to

==========
Add quic_logging.

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}
Committed:
https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4...
==========

[Fan Yang, 2017-01-13 15:37:53]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 15:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:06:50]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2017-01-13 17:31:29]

Description was changed from

==========
Add quic_logging.

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}
Committed:
https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4...
==========

to

==========
Add quic_logging.

Merge internal change 143128776

(Please do not revert this change if
net/quic/core/congestion_control/rtt_stats_test.cc failed in
Android_Cronet_Lollipop_Builder, I will land a fix asap.)
==========

[Fan Yang, 2017-01-13 17:31:58]

The CQ bit was checked by fayang@chromium.org

[Fan Yang, 2017-01-13 17:31:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2611613003/#ps200001
(title: "fix failed test?")

[commit-bot: I haz the power, 2017-01-13 17:32:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 18:49:15]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484328718190470,
"parent_rev": "2ed13221d52887cb7cdf5d37930fab028b521bec", "commit_rev":
"b25a2cd51e7758bf4c4f977cd01b17759e865bbf"}

[commit-bot: I haz the power, 2017-01-13 18:49:44]

Description was changed from

==========
Add quic_logging.

Merge internal change 143128776

(Please do not revert this change if
net/quic/core/congestion_control/rtt_stats_test.cc failed in
Android_Cronet_Lollipop_Builder, I will land a fix asap.)
==========

to

==========
Add quic_logging.

Merge internal change 143128776

(Please do not revert this change if
net/quic/core/congestion_control/rtt_stats_test.cc failed in
Android_Cronet_Lollipop_Builder, I will land a fix asap.)

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443626}
Committed:
https://chromium.googlesource.com/chromium/src/+/b25a2cd51e7758bf4c4f977cd01b...
==========

[commit-bot: I haz the power, 2017-01-13 18:49:45]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/b25a2cd51e7758bf4c4f977cd01b...