Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: net/quic/core/quic_spdy_session.cc

Issue 2611613003: Add quic_logging (Closed)
Patch Set: fix failed test? Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_session.cc ('k') | net/quic/core/quic_spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_spdy_session.cc
diff --git a/net/quic/core/quic_spdy_session.cc b/net/quic/core/quic_spdy_session.cc
index 0611e825c6b887471decf6c777ade83785f4c3b6..279646b95e6cdf119dec1878f618ad7bbf54f8b9 100644
--- a/net/quic/core/quic_spdy_session.cc
+++ b/net/quic/core/quic_spdy_session.cc
@@ -9,6 +9,7 @@
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_headers_stream.h"
#include "net/quic/platform/api/quic_bug_tracker.h"
+#include "net/quic/platform/api/quic_logging.h"
#include "net/quic/platform/api/quic_str_cat.h"
using base::StringPiece;
@@ -26,7 +27,7 @@ class HeaderTableDebugVisitor
: clock_(clock), headers_stream_hpack_visitor_(std::move(visitor)) {}
int64_t OnNewEntry(const HpackEntry& entry) override {
- DVLOG(1) << entry.GetDebugString();
+ QUIC_DVLOG(1) << entry.GetDebugString();
return (clock_->ApproximateNow() - QuicTime::Zero()).ToMicroseconds();
}
@@ -35,8 +36,8 @@ class HeaderTableDebugVisitor
clock_->ApproximateNow() -
QuicTime::Delta::FromMicroseconds(entry.time_added()) -
QuicTime::Zero());
- DVLOG(1) << entry.GetDebugString() << " " << elapsed.ToMilliseconds()
- << " ms";
+ QUIC_DVLOG(1) << entry.GetDebugString() << " " << elapsed.ToMilliseconds()
+ << " ms";
headers_stream_hpack_visitor_->OnUseEntry(elapsed);
}
@@ -270,7 +271,7 @@ class QuicSpdySession::SpdyFramerVisitor
return;
}
int compression_pct = 100 - (100 * frame_len) / payload_len;
- DVLOG(1) << "Net.QuicHpackCompressionPercentage: " << compression_pct;
+ QUIC_DVLOG(1) << "Net.QuicHpackCompressionPercentage: " << compression_pct;
}
void OnReceiveCompressedFrame(SpdyStreamId stream_id,
@@ -595,8 +596,8 @@ void QuicSpdySession::OnStreamFrameData(QuicStreamId stream_id,
const QuicStreamOffset offset =
stream->flow_controller()->highest_received_byte_offset();
const QuicStreamFrame frame(stream_id, fin, offset, StringPiece(data, len));
- DVLOG(1) << "De-encapsulating DATA frame for stream " << stream_id
- << " offset " << offset << " len " << len << " fin " << fin;
+ QUIC_DVLOG(1) << "De-encapsulating DATA frame for stream " << stream_id
+ << " offset " << offset << " len " << len << " fin " << fin;
OnStreamFrame(frame);
}
@@ -638,17 +639,17 @@ void QuicSpdySession::OnPushPromise(SpdyStreamId stream_id,
}
void QuicSpdySession::OnHeaderList(const QuicHeaderList& header_list) {
- DVLOG(1) << "Received header list for stream " << stream_id_ << ": "
- << header_list.DebugString();
+ QUIC_DVLOG(1) << "Received header list for stream " << stream_id_ << ": "
+ << header_list.DebugString();
if (prev_max_timestamp_ > cur_max_timestamp_) {
// prev_max_timestamp_ > cur_max_timestamp_ implies that
// headers from lower numbered streams actually came off the
// wire after headers for the current stream, hence there was
// HOL blocking.
QuicTime::Delta delta = prev_max_timestamp_ - cur_max_timestamp_;
- DVLOG(1) << "stream " << stream_id_
- << ": Net.QuicSession.HeadersHOLBlockedTime "
- << delta.ToMilliseconds();
+ QUIC_DLOG(INFO) << "stream " << stream_id_
+ << ": Net.QuicSession.HeadersHOLBlockedTime "
+ << delta.ToMilliseconds();
OnHeadersHeadOfLineBlocking(delta);
}
prev_max_timestamp_ = std::max(prev_max_timestamp_, cur_max_timestamp_);
@@ -706,8 +707,8 @@ bool QuicSpdySession::OnDataFrameHeader(QuicStreamId stream_id,
if (!IsConnected()) {
return true;
}
- DVLOG(1) << "DATA frame header for stream " << stream_id << " length "
- << length << " fin " << fin;
+ QUIC_DVLOG(1) << "DATA frame header for stream " << stream_id << " length "
+ << length << " fin " << fin;
fin_ = fin;
frame_len_ = length;
if (fin && length == 0) {
« no previous file with comments | « net/quic/core/quic_session.cc ('k') | net/quic/core/quic_spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698