Chromium Code Reviews Chromium Code Reviews
Issue
26114005:
Revert 159087 "Revert 159004 "Merge 158146 "[XHR] Abort method e..." (Closed)
DescriptionRevert 159087 "Revert 159004 "Merge 158146 "[XHR] Abort method e..."
Fixed compilation error.
> Revert 159004 "Merge 158146 "[XHR] Abort method execution when m..."
> This broke the 1599 branch.
>
> > Merge 158146 "[XHR] Abort method execution when m_loader->cancel..."
> >
> > > [XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry
> > >
> > > Calling cancel() on DocumentThreadableLoader may results in calling
> > > window.onload synchronously. If open(), send(), etc. are called on the same
> > > XMLHttpRequest object, it'll be hard to resolve conflict of states without
> > > losing spec conformance. This CL avoids that by just aborting execution of
> > > code for the outer method that calls internalAbort() if it returns false.
> > >
> > > BUG=292422
> > >
> > > Review URL: https://chromiumcodereview.appspot.com/24304004
> >
> > TBR=tyoshino@chromium.org
> >
> > Review URL: https://codereview.chromium.org/26209004
>
> TBR=tyoshino@chromium.org
>
> Review URL: https://codereview.chromium.org/26341006
TBR=kerz@chromium.org
BUG=292422
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159105
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
