Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 26209004: Merge 158146 "[XHR] Abort method execution when m_loader->cancel..." (Closed)

Created:
7 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Merge 158146 "[XHR] Abort method execution when m_loader->cancel..." > [XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry > > Calling cancel() on DocumentThreadableLoader may results in calling > window.onload synchronously. If open(), send(), etc. are called on the same > XMLHttpRequest object, it'll be hard to resolve conflict of states without > losing spec conformance. This CL avoids that by just aborting execution of > code for the outer method that calls internalAbort() if it returns false. > > BUG=292422 > > Review URL: https://chromiumcodereview.appspot.com/24304004 TBR=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159004

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 2 months ago (2013-10-07 05:09:21 UTC) #1
tyoshino (SeeGerritForStatus)
7 years, 2 months ago (2013-10-07 05:36:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r159004.

Powered by Google App Engine
This is Rietveld 408576698