Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 26341006: Revert 159004 "Merge 158146 "[XHR] Abort method execution when m..." (Closed)

Created:
7 years, 2 months ago by kerz_chromium
Modified:
7 years, 2 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert 159004 "Merge 158146 "[XHR] Abort method execution when m..." This broke the 1599 branch. > Merge 158146 "[XHR] Abort method execution when m_loader->cancel..." > > > [XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry > > > > Calling cancel() on DocumentThreadableLoader may results in calling > > window.onload synchronously. If open(), send(), etc. are called on the same > > XMLHttpRequest object, it'll be hard to resolve conflict of states without > > losing spec conformance. This CL avoids that by just aborting execution of > > code for the outer method that calls internalAbort() if it returns false. > > > > BUG=292422 > > > > Review URL: https://chromiumcodereview.appspot.com/24304004 > > TBR=tyoshino@chromium.org > > Review URL: https://codereview.chromium.org/26209004 TBR=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M branches/chromium/1599/LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M branches/chromium/1599/Source/core/xml/XMLHttpRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M branches/chromium/1599/Source/core/xml/XMLHttpRequest.cpp View 6 chunks +7 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
7 years, 2 months ago (2013-10-08 04:36:39 UTC) #1
kerz_chromium
7 years, 2 months ago (2013-10-08 04:36:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r159087.

Powered by Google App Engine
This is Rietveld 408576698