Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

BUG=25594
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/559ae993d158d63ef31d64b26c96a69087d907e3

[terry, 2017-01-06 18:31:22]

Please take a look at the CL and the CL for WebKit
https://codereview.chromium.org/2543703003

I was hoping to patch dart:builtin for _setupHooks() but was unable so I add
this DartiumSetup class to hookup the VMLibraryHooks.

[terry, 2017-01-06 20:41:16]

Description was changed from

==========
Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

BUG=25594
R=asiva@google.com
==========

to

==========
Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

BUG=25594
R=asiva@google.com
==========

[terry, 2017-01-06 20:41:16]

terry@google.com changed reviewers:
+ sigmund@google.com

[siva, 2017-01-06 21:33:43]

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dar...
runtime/bin/builtin.dart:356: }
Why does this class have to be in builtin.dart?
It does not seem to use anything from within this library.

This could easily be in a dartium specific library like html or js_interop.

[terry, 2017-01-06 21:41:17]

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dar...
runtime/bin/builtin.dart:356: }
On 2017/01/06 21:33:43, siva wrote:
> Why does this class have to be in builtin.dart?
> It does not seem to use anything from within this library.
> 
> This could easily be in a dartium specific library like html or js_interop.

I need to get to VMLibraryHooks which is in dart:_internal (its part of
internal_patch.dart)

How do I get to that?

Maybe I could try to fetch the VMLibraryHooks class in dart:_internal then set
the static field for VMLibraryHooks.resolvePackageUriFuture to point to my
Dartium method?

I can try doing that.

[siva, 2017-01-06 21:42:53]

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/2611353002/diff/40001/runtime/bin/builtin.dar...
runtime/bin/builtin.dart:356: }
On 2017/01/06 21:41:17, terry wrote:
> On 2017/01/06 21:33:43, siva wrote:
> > Why does this class have to be in builtin.dart?
> > It does not seem to use anything from within this library.
> > 
> > This could easily be in a dartium specific library like html or js_interop.
> 
> I need to get to VMLibraryHooks which is in dart:_internal (its part of
> internal_patch.dart)
> 
> How do I get to that?
> 
> Maybe I could try to fetch the VMLibraryHooks class in dart:_internal then set
> the static field for VMLibraryHooks.resolvePackageUriFuture to point to my
> Dartium method?
> 
> I can try doing that.

import 'dart:internal'; should get you access to that class

[terry, 2017-01-09 20:59:46]

Siva, I was able to not have to add code to dart:_builtin only to dart:_blink. 
PTAL.

[siva, 2017-01-10 01:56:46]

lgtm

[terry, 2017-01-10 15:25:19]

Description was changed from

==========
Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

BUG=25594
R=asiva@google.com
==========

to

==========
Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

BUG=25594
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/559ae993d158d63ef31d64b26c96a69087d907e3
==========

[terry, 2017-01-10 15:25:20]

Committed patchset #5 (id:80001) manually as
559ae993d158d63ef31d64b26c96a69087d907e3 (presubmit successful).