Added VMLibraryHooks setup for Dartium to support resolvePackageUri.

runtime/bin/builtin.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library builtin;
 // NOTE: Do not import 'dart:io' in builtin.
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_internal';
 import 'dart:isolate';
@@ skipping 325 matching lines @@
 // Register callbacks and hooks with the rest of the core libraries.
 _setupHooks() {
   _setupCompleted = true;
   VMLibraryHooks.resourceReadAsBytes = _resourceReadAsBytes;
 
   VMLibraryHooks.packageRootUriFuture = _getPackageRootFuture;
   VMLibraryHooks.packageConfigUriFuture = _getPackageConfigFuture;
   VMLibraryHooks.resolvePackageUriFuture = _resolvePackageUriFuture;
 }
 
+// Class used by Dartium to setup VMLibraryHooks.
+class DartiumSetup {
+  static Uri resolvePackageUri(String resolvedUri) native "Utils_resolvePackageUri";
+
+  static Uri _resolveUri(Uri packageUri) => resolvePackageUri(packageUri.toString());
+
+  static void _setupHooks() {
+    _setupCompleted = true;
+    VMLibraryHooks.resolvePackageUriFuture = _resolveUri;
+  }
+}

[siva, 2017/01/06 21:33:43]

Why does this class have to be in builtin.dart?
It does not seem to use anything from within this library.

This could easily be in a dartium specific library like html or js_interop.

[terry, 2017/01/06 21:41:17]

I need to get to VMLibraryHooks which is in dart:_internal (its part of
internal_patch.dart)

How do I get to that?

Maybe I could try to fetch the VMLibraryHooks class in dart:_internal then set
the static field for VMLibraryHooks.resolvePackageUriFuture to point to my
Dartium method?

I can try doing that.

[siva, 2017/01/06 21:42:53]

import 'dart:internal'; should get you access to that class

+
 // Handling of Resource class by dispatching to the load port.
 Future<List<int>> _resourceReadAsBytes(Uri uri) async {
   List response = await _makeLoaderRequest(_Dart_kResourceLoad, uri.toString());
   if (response[4] is String) {
     // Throw the error.
     throw response[4];
   } else {
     return response[4];
   }
 }
@@ skipping 30 matching lines @@
     if (_traceLoading) {
       _log("Exception when resolving package URI: $packageUri");
     }
     result = null;
   }
   if (_traceLoading) {
     _log("Resolved '$packageUri' to '$result'");
   }
   return result;
 }