Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2543703003: Added setting up VMLibraryHooks for Dartium to support resolvePageUri (Closed)

Created:
4 years ago by terry
Modified:
3 years, 11 months ago
CC:
reviews+dom_dartlang.org
Target Ref:
refs/heads/releases/2454_1
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added setting up VMLibraryHooks for Dartium to support resolvePageUri #

Total comments: 7

Patch Set 3 : Updated to use code in _blink #

Patch Set 4 : Removed native resolver for dart:_builtin #

Patch Set 5 : Incorporated Siva suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M Source/bindings/core/dart/DartApplicationLoader.h View 1 2 3 4 3 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/core/dart/DartApplicationLoader.cpp View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M Source/bindings/core/dart/DartController.cpp View 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/dart/DartNativeUtilities.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/dart/DartNativeUtilities.cpp View 1 2 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
terry
3 years, 11 months ago (2017-01-06 18:28:59 UTC) #2
terry
3 years, 11 months ago (2017-01-06 18:46:05 UTC) #4
terry
3 years, 11 months ago (2017-01-06 20:42:03 UTC) #6
siva
LGTM with one comment about setting up stuff in builtin library. https://codereview.chromium.org/2543703003/diff/20001/Source/bindings/core/dart/DartApplicationLoader.cpp File Source/bindings/core/dart/DartApplicationLoader.cpp (right): ...
3 years, 11 months ago (2017-01-06 21:39:33 UTC) #7
terry
Siva, I moved the code from dart:_builtin to dart:_blink. PTAL. https://codereview.chromium.org/2543703003/diff/20001/Source/bindings/core/dart/DartApplicationLoader.h File Source/bindings/core/dart/DartApplicationLoader.h (right): https://codereview.chromium.org/2543703003/diff/20001/Source/bindings/core/dart/DartApplicationLoader.h#newcode138 ...
3 years, 11 months ago (2017-01-09 21:06:02 UTC) #8
siva
lgtm
3 years, 11 months ago (2017-01-10 01:56:00 UTC) #9
terry
3 years, 11 months ago (2017-01-10 15:20:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
cdb44f3ddd32f2594e77ef26cd806891597cc1d9 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698