Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2611093002:
[Devtools] Fixed bug on hover waterfall in network panel (Closed)
Description[Devtools] Fixed bug on hover waterfall in network panel
This patch fixes a bug with the header of waterfall column in network
panel was clipping the arrow and hiding the times in the header.
See: http://imgur.com/a/7rP4E
R=dgozman
BUG=665697
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2513753002
Cr-Commit-Position: refs/heads/master@{#433290}
(cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9)
Review-Url: https://codereview.chromium.org/2611093002
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
lgtm
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 NOTRY=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) ==========
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 NOTRY=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) ==========
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483585344044600, "parent_rev":
"4a23384c2843bf778ed985bdd33fd10c094b65df", "commit_rev":
"d3405cac66d568235d5abf4231f73282c74e833e"}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) Review-Url: https://codereview.chromium.org/2611093002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
