Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2513753002:
[Devtools] Fixed bug on hover waterfall in network panel (Closed)
|
Created:
4 years, 1 month ago by allada Modified:
4 years, 1 month ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fixed bug on hover waterfall in network panel
This patch fixes a bug with the header of waterfall column in network
panel was clipping the arrow and hiding the times in the header.
See: http://imgur.com/a/7rP4E
R=dgozman
BUG=665697
Committed: https://crrev.com/a5cad337d45510b109937cf71a8a928d3a8022b9
Cr-Commit-Position: refs/heads/master@{#433290}
Patch Set 1 #
Total comments: 2
Patch Set 2 : [Devtools] Fixed bug on hover waterfall in network panel #Messages
Total messages: 25 (13 generated)
PTL
PTL
I'll add a test for it when the other patch lands... but I'd like to get this on before the merge.
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. R=dgozman BUG=665697 ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ==========
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2513753002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css (right): https://codereview.chromium.org/2513753002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:371: background-color: hsl(0, 0%, 90%) missing semicolon
done https://codereview.chromium.org/2513753002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css (right): https://codereview.chromium.org/2513753002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:371: background-color: hsl(0, 0%, 90%) On 2016/11/17 22:14:53, dgozman wrote: > missing semicolon Done.
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman NOTRY=true BUG=665697 ==========
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2513753002/#ps20001 (title: "[Devtools] Fixed bug on hover waterfall in network panel")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by allada@chromium.org
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman NOTRY=true BUG=665697 ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 ========== to ========== [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG=665697 Committed: https://crrev.com/a5cad337d45510b109937cf71a8a928d3a8022b9 Cr-Commit-Position: refs/heads/master@{#433290} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a5cad337d45510b109937cf71a8a928d3a8022b9 Cr-Commit-Position: refs/heads/master@{#433290} |
