Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm b/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
index a3839aefd10e9f9938942739af9734022ee96133..ee97a9764ee7e1f6cbf9103a56ea22e36b7ffc29 100644
--- a/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
@@ -6,7 +6,7 @@
#include "base/ios/weak_nsobject.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "components/autofill/core/browser/personal_data_manager.h"
@@ -52,8 +52,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
PersonalDataManagerObserverBridgeDelegate> {
std::string _locale; // User locale.
autofill::PersonalDataManager* _personalDataManager;
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_AutofillCollectionViewController;
ios::ChromeBrowserState* _browserState;
std::unique_ptr<autofill::PersonalDataManagerObserverBridge> _observer;
BOOL _deletionInProgress;
@@ -86,15 +84,13 @@ typedef NS_ENUM(NSInteger, ItemType) {
[self updateEditButton];
[self loadModel];
-
- _propertyReleaser_AutofillCollectionViewController.Init(
- self, [AutofillCollectionViewController class]);
}
return self;
}
- (void)dealloc {
_personalDataManager->RemoveObserver(_observer.get());
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698