Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: ios/chrome/browser/ui/reader_mode/reader_mode_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
diff --git a/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm b/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
index 471394af3ed3ea69e8bda6d2fad4a39cd84a66ba..d483e862b8bd12834ab6193b88e3904dd578b62c 100644
--- a/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
+++ b/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
@@ -4,7 +4,7 @@
#import "ios/chrome/browser/ui/reader_mode/reader_mode_view.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/dom_distiller/distiller_viewer.h"
#import "ios/chrome/browser/ui/material_components/activity_indicator.h"
@@ -19,7 +19,6 @@ const CGFloat kMinHeight = kMinWidth;
@interface ReaderModeView ()<MDCActivityIndicatorDelegate> {
std::unique_ptr<dom_distiller::DistillerViewer> _viewer;
- base::mac::ObjCPropertyReleaser _propertyReleaser_ReaderModeView;
}
@property(nonatomic, retain) MDCActivityIndicator* activityIndicator;
@property(nonatomic, copy) ProceduralBlock animateOutCompletionBlock;
@@ -37,7 +36,6 @@ const CGFloat kMinHeight = kMinWidth;
delegate:(id<ReaderModeViewDelegate>)delegate {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_ReaderModeView.Init(self, [ReaderModeView class]);
_delegate = delegate;
self.backgroundColor = [UIColor whiteColor];
@@ -80,6 +78,11 @@ const CGFloat kMinHeight = kMinWidth;
return nil;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)start {
[self.activityIndicator startAnimating];
}

Powered by Google App Engine
This is Rietveld 408576698