Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/new_tab_page_view.mm
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_view.mm b/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
index 7f9f7ab87e63cfe169c902b229e1c613ae416218..7c675c621e2c9062e548b6c215dbb3cfeb5c8fc1 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
@@ -5,21 +5,13 @@
#import "ios/chrome/browser/ui/ntp/new_tab_page_view.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
#include "ios/chrome/browser/ui/ui_util.h"
-@implementation NewTabPageView {
- @private
- // The objects pointed to by |tabBar_| and |scrollView_| are owned as
- // subviews already.
- __unsafe_unretained NewTabPageBar* tabBar_; // weak
- __unsafe_unretained UIScrollView* scrollView_; // weak
-
- base::mac::ObjCPropertyReleaser propertyReleaser_NewTabPageView_;
-}
+@implementation NewTabPageView
@synthesize scrollView = scrollView_;
@synthesize tabBar = tabBar_;
@@ -29,7 +21,6 @@
andTabBar:(NewTabPageBar*)tabBar {
self = [super initWithFrame:frame];
if (self) {
- propertyReleaser_NewTabPageView_.Init(self, [NewTabPageView class]);
[self addSubview:scrollView];
[self addSubview:tabBar];
scrollView_ = scrollView;
@@ -48,6 +39,11 @@
return nil;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)setFrame:(CGRect)frame {
// When transitioning the iPhone xib to an iPad idiom, the setFrame call below
// can sometimes fire a scrollViewDidScroll event which changes the

Powered by Google App Engine
This is Rietveld 408576698