Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
index ec65f615c8b837fb8ab11f21d5b4546ceeee4546..e9876364eadac29599bc24b26cc05394217155bd 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
@@ -8,7 +8,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
#include "components/prefs/pref_service.h"
@@ -108,11 +108,8 @@ enum {
@interface NewTabPageController () {
ios::ChromeBrowserState* browserState_; // Weak.
id<UrlLoader> loader_; // Weak.
- id<CRWSwipeRecognizerProvider> swipeRecognizerProvider_; // Weak.
id<NewTabPageControllerObserver> newTabPageObserver_; // Weak.
- NewTabPageView* newTabPageView_;
-
base::scoped_nsobject<RecentTabsPanelController> openTabsController_;
// Has the scrollView been initialized.
BOOL scrollInitialized_;
@@ -127,8 +124,6 @@ enum {
base::WeakNSProtocol<id<WebToolbarDelegate>> webToolbarDelegate_;
base::scoped_nsobject<TabModel> tabModel_;
-
- base::mac::ObjCPropertyReleaser propertyReleaser_NewTabPageController_;
}
// Load and bring panel into view.
@@ -176,8 +171,6 @@ enum {
self = [super initWithNibName:nil url:url];
if (self) {
DCHECK(browserState);
- propertyReleaser_NewTabPageController_.Init(self,
- [NewTabPageController class]);
browserState_ = browserState;
loader_ = loader;
newTabPageObserver_ = ntpObserver;
@@ -282,6 +275,7 @@ enum {
[bookmarkController_ setDelegate:nil];
[openTabsController_ setDelegate:nil];
[[NSNotificationCenter defaultCenter] removeObserver:self];
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698