Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm b/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
index 088223612c52ec76fd15219759486b7b96e874e9..cf416508422abc7266a0a00bd65f8631c687eac6 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
@@ -4,7 +4,7 @@
#import "ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_menu_item.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
@@ -19,9 +19,7 @@ namespace {
CGFloat kTrailingMargin = 16.0;
} // namespace
-@interface BookmarkMenuCell () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkMenuCell;
-}
+@interface BookmarkMenuCell ()
// Set to YES if the cell can be selected.
@property(nonatomic, assign) BOOL isSelectable;
// Set to YES if the cell should animate on selection.
@@ -46,8 +44,6 @@ CGFloat kTrailingMargin = 16.0;
reuseIdentifier:(NSString*)reuseIdentifier {
self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
if (self) {
- _propertyReleaser_BookmarkMenuCell.Init(self, [BookmarkMenuCell class]);
-
// Create icon view.
base::scoped_nsobject<UIImageView> iconView([[UIImageView alloc] init]);
_iconView = iconView;
@@ -109,6 +105,11 @@ CGFloat kTrailingMargin = 16.0;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)prepareForReuse {
self.shouldAnimateHighlight = NO;
self.isSelectable = NO;

Powered by Google App Engine
This is Rietveld 408576698