Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
index 95c9cbfa4802ba1d4f16a313de4d6178aea5e217..2c27bae6ca46285611d3289efd33ec3d0b47f57b 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
@@ -9,7 +9,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
#include "base/mac/bind_objc_block.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -59,9 +59,6 @@ const int64_t kLastUsedFolderNone = -1;
// The parent controller on top of which the UI needs to be presented.
base::WeakNSObject<UIViewController> _parentController;
-
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_BookmarkInteractionController;
}
// The bookmark model in use.
@@ -129,8 +126,6 @@ const int64_t kLastUsedFolderNone = -1;
parentController:(UIViewController*)parentController {
self = [super init];
if (self) {
- _propertyReleaser_BookmarkInteractionController.Init(
- self, [BookmarkInteractionController class]);
// Bookmarks are always opened with the main browser state, even in
// incognito mode.
_currentBrowserState = browserState;
@@ -148,6 +143,7 @@ const int64_t kLastUsedFolderNone = -1;
- (void)dealloc {
_bookmarkBrowser.delegate = nil;
_bookmarkEditor.delegate = nil;
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698