Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm b/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
index 45c6b0eee9d0507d8ce80ba59114b452a80d253f..e7255c127b63baf032322084bca5edd946da8652 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
@@ -6,7 +6,7 @@
#include "base/hash.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/strings/sys_string_conversions.h"
#include "components/bookmarks/browser/bookmark_node.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
@@ -33,9 +33,7 @@ BOOL NumberIsValidMenuItemType(int number) {
}
} // namespace bookmarks
-@interface BookmarkMenuItem () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkMenuItem;
-}
+@interface BookmarkMenuItem ()
// Redefined to be read-write.
@property(nonatomic, assign) const BookmarkNode* folder;
@property(nonatomic, assign) const BookmarkNode* rootAncestor;
@@ -51,12 +49,9 @@ BOOL NumberIsValidMenuItemType(int number) {
@synthesize sectionTitle = _sectionTitle;
@synthesize type = _type;
-- (instancetype)init {
- self = [super init];
- if (self) {
- _propertyReleaser_BookmarkMenuItem.Init(self, [BookmarkMenuItem class]);
- }
- return self;
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
}
- (UIAccessibilityTraits)accessibilityTraits {

Powered by Google App Engine
This is Rietveld 408576698