Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm
index cdf3f042b9d9be3f696275ecf670a187bc1c4718..855c955654788450fd116d0a14832806e92ce27e 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm
@@ -4,16 +4,14 @@
#import "ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
#import "ios/chrome/browser/ui/material_components/activity_indicator.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
#import "ios/third_party/material_components_ios/src/components/ActivityIndicator/src/MaterialActivityIndicator.h"
-@interface BookmarkHomeWaitingView ()<MDCActivityIndicatorDelegate> {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkHomeWaitingView;
-}
+@interface BookmarkHomeWaitingView ()<MDCActivityIndicatorDelegate>
@property(nonatomic, retain) MDCActivityIndicator* activityIndicator;
@property(nonatomic, copy) ProceduralBlock animateOutCompletionBlock;
@end
@@ -26,8 +24,6 @@
- (instancetype)initWithFrame:(CGRect)frame {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_BookmarkHomeWaitingView.Init(
- self, [BookmarkHomeWaitingView class]);
self.backgroundColor = bookmark_utils_ios::mainBackgroundColor();
self.autoresizingMask =
UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
@@ -35,6 +31,11 @@
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)startWaiting {
dispatch_time_t delayForIndicatorAppearance =
dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.5 * NSEC_PER_SEC));

Powered by Google App Engine
This is Rietveld 408576698